From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/switchy-window 682bcec0a6: Release 1.2: no code changes but don't suggest adding lambdas to hooks Date: Tue, 11 Apr 2023 12:40:19 -0400 Message-ID: References: <168122524652.26571.12717876454918406453@vcs2.savannah.gnu.org> <20230411150046.C8002C13916@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10950"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Tassilo Horn To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 11 18:41:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmH3o-0002c1-2d for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Apr 2023 18:41:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmH2p-0001mb-Kn; Tue, 11 Apr 2023 12:40:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmH2o-0001mR-Ff for emacs-devel@gnu.org; Tue, 11 Apr 2023 12:40:34 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmH2k-0007WK-QQ; Tue, 11 Apr 2023 12:40:34 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8451710012D; Tue, 11 Apr 2023 12:40:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5FC2810009E; Tue, 11 Apr 2023 12:40:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1681231226; bh=NatpqcPBb3eKuwz98hn3kwHzf8Pja2HJ7i2JKkCRnac=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=U5tCARsPN4Z8vnkvct+Y7HR75RBKusPS3tRRZqho1f0GMle7EuaTuTZSiOsiXEkHK 9hKfLajQMORUUwc67usYCtsN08DjqaUzNe7lfkDTEdjy5m1i9BaLvD22+hLCiJuw59 GAgTEXKoTyTgrb8v0NeOKTm5hu9j0VQ/ozB5vjdYOXtK9WhjRb+kdkY4rJMjhI2cJQ H/T39bXIbxoefKYaAQwYukkNDU8jw06Cm1tQJb67/gnJA+/gY7zxEpsk/x1mBlh9NJ yHomvFzqCaISrOeIA0hvzHlK3zEvwFre4s+ht4f4VMrJjatZRsofJdKbYJbcN1kXFY Ke/zagasQtSsg== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 53B0E120254; Tue, 11 Apr 2023 12:40:26 -0400 (EDT) In-Reply-To: <20230411150046.C8002C13916@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Tue, 11 Apr 2023 11:00:46 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305240 Archived-At: > ;; Or as a substitute for `other-window'. > +(defun my-switchy-window-set-or-unset-key () > + (if switchy-window-minor-mode > + (keymap-global-set " " > + #'switchy-window) > + (keymap-global-unset " "))) > + > (add-hook 'switchy-window-minor-mode-hook > - (lambda () > - (if switchy-window-minor-mode > - (keymap-global-set " " > - #'switchy-window) > - (keymap-global-unset " ")))) > + #'my-switchy-window-set-or-unset-key) > ``` Why not just (keymap-set switchy-window-minor-mode-map " " #'switchy-window) ? Stefan