From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Thu, 08 Jun 2023 12:54:37 -0400 Message-ID: References: <834jnl4ub9.fsf@gnu.org> <831qio4z3d.fsf@gnu.org> <83bkhq2s19.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan Smith , Jimmy Aguilar Mena , 63913@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 08 18:55:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7Iv3-0003Ye-Cs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jun 2023 18:55:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7Iui-0003pj-3e; Thu, 08 Jun 2023 12:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Iuc-0003p7-9w for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 12:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7Iuc-0007Sx-1J for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7Iub-0007qW-So for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 12:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-submit@debbugs.gnu.org id=B63913.168624328630134 (code B ref 63913); Thu, 08 Jun 2023 16:55:01 +0000 Original-Received: (at 63913) by debbugs.gnu.org; 8 Jun 2023 16:54:46 +0000 Original-Received: from localhost ([127.0.0.1]:57415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7IuM-0007px-CT for submit@debbugs.gnu.org; Thu, 08 Jun 2023 12:54:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7IuK-0007pa-Rj for 63913@debbugs.gnu.org; Thu, 08 Jun 2023 12:54:45 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 40B2C803C3; Thu, 8 Jun 2023 12:54:39 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 10DEC80250; Thu, 8 Jun 2023 12:54:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1686243278; bh=6i/zCTLx8u549AbWzJpKzf0MKeItvY/49wr+EKisxK0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iePxGCFgKjSl+L+px7xXv+JqE+VxR36cCo5neIGG8GE5IKJsBN1mJJH0QenAfcuKz NYp3zQzmjFCAnrG0Vh/9joxxEDibiITYSd1ylhvBkzBWlxzoXc8Xuw3ya/qL8JM64N lF7AoVBahaPuz4ssiqTcgFB7uaQ1FBAhGqfGQUU5qK7Yv217AFCOQoNe9o+zMHk+/s uFypub3Ab6QAtr2lYaewIYsrimZ7d29pG55eibaArsFkL2Qepu/aYisPn9MvP1zYEH HJSCdADMqO0kxznpNL/ygmAhZoQfjyvXEBa7QDGmwiegQJOypwA0Rjs1pZ8eDRdAQc P4cVph8YZNBJw== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E513212019B; Thu, 8 Jun 2023 12:54:37 -0400 (EDT) In-Reply-To: <83bkhq2s19.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Jun 2023 12:59:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263133 Archived-At: > I've added to the discussion folks that know more about this than I > do. Stefan, Ergus: any comments to the issue or about the proposed > patch? (I'm not sure we need to change the message when we do "ding", > but that's a separate issue, I think.) The patch looks good to me. Thank you, Morgan. Stefan