From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65516: 30.0.50; Edebug behavior of signaling errors in &or Date: Sun, 27 Aug 2023 11:30:11 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , 65516@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 27 17:31:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qaHjP-0003df-1A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Aug 2023 17:31:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaHj8-0006FZ-SQ; Sun, 27 Aug 2023 11:30:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaHj6-0006FQ-UU for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2023 11:30:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qaHj6-0000iL-M8 for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2023 11:30:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qaHjC-0006XD-9l for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2023 11:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2023 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65516 X-GNU-PR-Package: emacs Original-Received: via spool by 65516-submit@debbugs.gnu.org id=B65516.169315022925076 (code B ref 65516); Sun, 27 Aug 2023 15:31:02 +0000 Original-Received: (at 65516) by debbugs.gnu.org; 27 Aug 2023 15:30:29 +0000 Original-Received: from localhost ([127.0.0.1]:45985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaHif-0006WO-Da for submit@debbugs.gnu.org; Sun, 27 Aug 2023 11:30:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaHia-0006W8-NV for 65516@debbugs.gnu.org; Sun, 27 Aug 2023 11:30:28 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 094428076B; Sun, 27 Aug 2023 11:30:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693150211; bh=WTuiZu02XkRZhgzAX0joqGt92Qw0ecylpgIPzyhzJm0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HYSrsBC/Hk4TFKblF5GmDSRpIZiuj3B67/rjIWmzEV31EGrEml+QwQry3FCs5fwA1 slS4A84LHzRN1KolXcXRC069SADPa+UAu9klIBHVOZiIE3o9VNU6Hm6t428zy9dJJI WfTlVODwUP+tXByIX8+eh2bxHbf/E8KLxTI21ABX6RwkhtVy6bKGIcNOcWVlDF9oh5 G1Ck3Lrh+WkpkdWis/SeQ3NjhCLfoCHmIhztNKHF7cahsZe49jPbwSmALyLLv2k8sa QTGUnV9hyfLQOxqAX7zh3SPCw//QAx3+flz18egNnUbRuCO0tO9aPseJPV57H4FEYe jE01wGxxLd/ag== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CF06E8019D; Sun, 27 Aug 2023 11:30:11 -0400 (EDT) Original-Received: from pastel (unknown [108.175.234.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A0D3E120323; Sun, 27 Aug 2023 11:30:11 -0400 (EDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sun, 27 Aug 2023 08:26:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268560 Archived-At: >> See bug#41988 for a case where we didn't want a failure in one >> "definition form" to be allowed to continue matching in a second branch >> of an `&or` (tho this was arguably because some of the code executed >> along the way had side-effects that can't be undone). > > Hurrah! :-) Yes, that's it! Thank you so much, that made my day! > > As a fix, I'd like to propose to remove 'gate' as a debug spec entirely. It's worth a try but: - We should come up with a better fix for bug#41988/bug#41853 first. - We need to check the impact on current users of that gate mechanism. For the second, `grep -C9 debug **/*.el | grep '\'` finds only one direct user of `gate` inside Emacs or (Non)GNU ELPA, i.e. `cl-macs.el` lisp/emacs-lisp/cl-macs.el:1224:;; '(&or (loop-var . [&or nil loop-var]) [gate symbolp])) lisp/emacs-lisp/cl-macs.el:2858: (gate gv-place &optional form)]) lisp/emacs-lisp/cl-macs.el:2989: (gate ;; FIXME: Why? but there might be users elsewhere. And more importantly it's used within - strings - `&define` - quoted symbols? The last one seems to be an old deprecated mechanism (a comment suggests it should be replaced by a string) that just has never been actively deprecated, so maybe we can disregard it. But the first two are used in a lot of places, so it might be more problematic. Stefan