From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 60845-done@debbugs.gnu.org,
Daniel Mendler <mail@daniel-mendler.de>,
Gregory Heytings <gregory@heytings.org>,
arstoffel@gmail.com, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)
Date: Tue, 10 Oct 2023 17:23:42 -0400 [thread overview]
Message-ID: <jwvedi2tbov.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> (Jim Porter's message of "Tue, 10 Oct 2023 13:07:50 -0700")
>> Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've
>> fixed this on the Eshell side by always providing Pcomplete with the
>> arguments in their string form. Could everyone try the patch out to make
>> sure things still work?
>> In particular, see the cases in the following bugs: bug#60464, bug#60021,
>> and bug#59956.
>
> Since there have been no further comments in the last month, I've now merged
> my patch to the master branch as 239db5d5162. If anyone sees any issues
> resulting from this, feel free to back it out, file a bug, and/or let me
> know directly.
Thanks Jim,
Stefan
prev parent reply other threads:[~2023-10-10 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 1:50 bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Jim Porter
2023-01-22 21:34 ` Jim Porter
2023-01-22 21:35 ` Jim Porter
2023-01-30 7:14 ` Jim Porter
2023-01-30 14:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-31 2:00 ` Jim Porter
2023-09-05 23:36 ` Stefan Kangas
2023-09-06 0:47 ` Jim Porter
2023-09-06 1:37 ` Jim Porter
2023-10-10 20:07 ` Jim Porter
2023-10-10 21:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvedi2tbov.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=60845-done@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=gregory@heytings.org \
--cc=jporterbugs@gmail.com \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.