From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72559: 31.0.50; profiler-report-write-profile produced unreadable data Date: Sat, 17 Aug 2024 10:07:59 -0400 Message-ID: References: <87wmko35yn.fsf@localhost> <877ccomqg3.fsf@protonmail.com> <867ccojqsd.fsf@gnu.org> <86plq731qz.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36534"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72559@debbugs.gnu.org, pipcet@protonmail.com, yantar92@posteo.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 17 16:08:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfK6c-0009Ny-5k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Aug 2024 16:08:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfK6S-0005Ny-OG; Sat, 17 Aug 2024 10:08:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfK6R-0005Nj-7C for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 10:08:23 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfK6Q-0001S9-UX for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 10:08:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=hbyvhNo0gpPn4WWdPx/UP8Q2AnTi0gHGGZRWkkwcAM8=; b=MMjiHlqDi8zoVVRGOhwQto9dnhE3AoEeS4XDLb+B39Geklq/QYmYXemTMuMzAdP7edJH5ZIdsAEYheg6CbFH01jLAaru6Vh0FzKbqMREFBxB1/Whl9w5AT4m2zTaauQQKE76QrGPVOk+1ZxyGCjqha7gg03Nd9u7omwNRxIaYqWZJ/Pe+BpoT1hh98DNBWn7wkXyHgecl307XydyEVzsSIoGdhI+xn+MnXCiBPE0boslkD0O5/3rcpytcJ+8aKcQEF6TIMXnCMCFCne+JaCvz4PbR9/750+4/XlPfjvcvjC7/Du+QEYEocOAqeK2tAUV73zi/ux5TaURwlQ/gdxmNw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfK73-000283-Qi for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 10:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2024 14:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72559 X-GNU-PR-Package: emacs Original-Received: via spool by 72559-submit@debbugs.gnu.org id=B72559.17239037298162 (code B ref 72559); Sat, 17 Aug 2024 14:09:01 +0000 Original-Received: (at 72559) by debbugs.gnu.org; 17 Aug 2024 14:08:49 +0000 Original-Received: from localhost ([127.0.0.1]:54794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfK6r-00027Z-0l for submit@debbugs.gnu.org; Sat, 17 Aug 2024 10:08:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfK6o-00027I-MM for 72559@debbugs.gnu.org; Sat, 17 Aug 2024 10:08:47 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 08F21808A4; Sat, 17 Aug 2024 10:08:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1723903680; bh=suojfz2M/MMZREX3mNsGtswZ8aJ9fjbIg9sur/N9Uqk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FZuYIrOw5qtc1e5+0E2WGg9jr0ZhkHxbKOxEcGpyMBvXzDoDEugoKynAL0aAUbe1/ lO6bsES0g4NfWRG9oYZsQ9DFSC0+iSFEMGffpbH18Mm1BaLACo1XNl3sy4JBaIAf3V iYlQZdv9Xlb2/+EGSIDzsQ9QtQlZUJVQz/1v4RR+Vh1HOQSpG7fKka5CWmrl15I//7 Ns9uyDGBwyGg1AKm2wDo6OUb+gdSzMC+986BJVHFFH252cDPeoCVi7w1GFQnwSrZWi Gh8dWHoZZi2CTP9VbZfQiDz3gIkI2xSY/3FNEy4FUN9mcnK5pfPWFMnlLokk+084Gr OQ3WDfP/xZizQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8709B8014E; Sat, 17 Aug 2024 10:08:00 -0400 (EDT) Original-Received: from alfajor (unknown [216.154.9.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4FE6A12062C; Sat, 17 Aug 2024 10:08:00 -0400 (EDT) In-Reply-To: <86plq731qz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Aug 2024 13:03:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290266 Archived-At: > This seems to avoid errors, but I still see problems in the profile > read from a file, which is displayed like this: > > Samples % Function > 35 31% redisplay_internal (C function) > 28 25% + command-execute > 28 25% Automatic GC > 8 7% + # > 7 6% + ... > 4 3% + # > 2 1% + # > > Those "" thingies are actually written in the file as > "#" strings, and I suspect that they should > have been written as function objects, not as strings. I don't think we want to write them as function objects, because then we'll again bump into the problem that some function objects contain unprintable objects like buffers. Better would be to print the "#" strings as-is instead of printing them as #. Of course, we could also try to print the function objects and then verify that they are printed readably and only print them as strings when that fails. Stefan