From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72819: [PATCH] Correctly include fixed strings before a prefix wildcard in PCM Date: Sun, 08 Sep 2024 07:15:10 -0400 Message-ID: References: <86cylfzzp3.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35833"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , 72819@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 08 13:16:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snFtv-0009AX-LE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Sep 2024 13:16:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snFti-0005hE-Af; Sun, 08 Sep 2024 07:16:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snFtg-0005go-8l for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 07:16:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snFtf-0005eA-Vk for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 07:16:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Smp++beyCmY31uAT2i1c/TYRgTNeDvg58Ob2chr/3HM=; b=B9tI6gZqUvG0/Cdf6TKy6JvyqaZNFk0+PADMQHPzQ2l5T/uWUXNXLpL+xXagwz4WK2qaihmnJhFdbpX0VoqHtBWqZp7Xn6eJapzLGlCALRlPP3gbXgE+0t70g1i1aVHCuabawD5keebOp2NkxStqXmEWHulUdohvGfiSh+VdR/ibBLAD0jTEku82w4eepFbkALR2N7vHJCFoY2FDNNxeRBCad3XOpAmcldJL9+8zt67fAfgX3oao0nc0C/RnMoz0OPJibgimJH1biPCvkpAoxWY2izdk+qIjvahw6EDypbsZBQ4Gw2QSxIYpa4FkfVFx8aZyAPaRpq73fYvhufhPSQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snFti-0006Br-0p for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2024 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72819 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72819-submit@debbugs.gnu.org id=B72819.172579414123765 (code B ref 72819); Sun, 08 Sep 2024 11:16:01 +0000 Original-Received: (at 72819) by debbugs.gnu.org; 8 Sep 2024 11:15:41 +0000 Original-Received: from localhost ([127.0.0.1]:58054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snFtM-0006BE-SH for submit@debbugs.gnu.org; Sun, 08 Sep 2024 07:15:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snFtK-0006Ax-HV for 72819@debbugs.gnu.org; Sun, 08 Sep 2024 07:15:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0F230803AD; Sun, 8 Sep 2024 07:15:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1725794125; bh=MBFUvq7fI7mp55Cd8pT5T1+s17x25CSWeZBOJ2AqS2k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kJ/QC7y4F7Dcu+kT5jIQ43B06mA+W7kXRxIpPsoXULnazV3FkvGDiPDj7nqm6O5Nt pDv5y+xqLhoYhQQ9fn5yP0dGdrwIXEBoz6lVAQ0TgCtUhWVdRbB+15TBD1ASC5Q0F3 +AxHd3/9TdxenLjEaZUJz+QfNzcRzsp1p80BaYAhu7VdHejS65iv8NsTB3Pr0vRkwG SRko5chTMYTNF16TXDmhM7eivm2/6hSaaGJkyClGFd/a1BADlyvL5TbCLAtTDKx+M0 cHOtP3ZNcTtWYgBHt7C67PUxpno3rAb1gORYyH0F4/QswAdu06TrEA65D/xZZ1SgpR Pq3w70BRnKovQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 338FA80262; Sun, 8 Sep 2024 07:15:25 -0400 (EDT) Original-Received: from asado (31-131-247-74.ip252.fastwebnet.it [31.131.247.74]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D7CE612032C; Sun, 8 Sep 2024 07:15:19 -0400 (EDT) In-Reply-To: <86cylfzzp3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Sep 2024 10:32:24 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291442 Archived-At: > Ping! Stefan, any comments? Looks good to me. [ Maybe we could appoint Spencer as maintainer of that code :-) ] Stefan >> Cc: monnier@iro.umontreal.ca >> From: Spencer Baugh >> Date: Mon, 26 Aug 2024 10:17:05 -0400 >> >> Tags: patch >> >> >> In 63a48252306a631dc07d62d19311433c7877bd27 I fixed a bug with >> the PCM implementation of substring completion, relating to the >> handling of PCM wildcards. >> >> However, this fix was incomplete. This change completes the fix by >> also including a fixed string if it appears before a `prefix' >> wildcard, even if try-completion doesn't discover that fixed string >> grows to a unique completion. >> >> I discovered this bug while working on enhancements to PCM completion >> related to completion-pcm-leading-wildcard.