From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Spencer Baugh <sbaugh@janestreet.com>, 72819@debbugs.gnu.org
Subject: bug#72819: [PATCH] Correctly include fixed strings before a prefix wildcard in PCM
Date: Sun, 08 Sep 2024 07:15:10 -0400 [thread overview]
Message-ID: <jwved5ucs8r.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86cylfzzp3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Sep 2024 10:32:24 +0300")
> Ping! Stefan, any comments?
Looks good to me.
[ Maybe we could appoint Spencer as maintainer of that code :-) ]
Stefan
>> Cc: monnier@iro.umontreal.ca
>> From: Spencer Baugh <sbaugh@janestreet.com>
>> Date: Mon, 26 Aug 2024 10:17:05 -0400
>>
>> Tags: patch
>>
>>
>> In 63a48252306a631dc07d62d19311433c7877bd27 I fixed a bug with
>> the PCM implementation of substring completion, relating to the
>> handling of PCM wildcards.
>>
>> However, this fix was incomplete. This change completes the fix by
>> also including a fixed string if it appears before a `prefix'
>> wildcard, even if try-completion doesn't discover that fixed string
>> grows to a unique completion.
>>
>> I discovered this bug while working on enhancements to PCM completion
>> related to completion-pcm-leading-wildcard.
prev parent reply other threads:[~2024-09-08 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 14:17 bug#72819: [PATCH] Correctly include fixed strings before a prefix wildcard in PCM Spencer Baugh
2024-08-27 10:59 ` Eli Zaretskii
2024-09-10 16:31 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 9:27 ` Eli Zaretskii
2024-09-07 7:32 ` Eli Zaretskii
2024-09-08 11:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwved5ucs8r.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=72819@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.