From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: diff.el now uses diff-mode Date: 11 Feb 2004 13:11:26 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1076523181 26160 80.91.224.253 (11 Feb 2004 18:13:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 11 Feb 2004 18:13:01 +0000 (UTC) Cc: dapfy@t-online.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Feb 11 19:12:39 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Aqyqk-0006D9-00 for ; Wed, 11 Feb 2004 19:12:38 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Aqyqk-0000uD-00 for ; Wed, 11 Feb 2004 19:12:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqyqW-0006QU-Jf for emacs-devel@quimby.gnus.org; Wed, 11 Feb 2004 13:12:24 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AqyqD-0006NZ-91 for emacs-devel@gnu.org; Wed, 11 Feb 2004 13:12:05 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Aqypg-000647-Mn for emacs-devel@gnu.org; Wed, 11 Feb 2004 13:12:03 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Aqypf-000626-Tz; Wed, 11 Feb 2004 13:11:32 -0500 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 2481121460; Wed, 11 Feb 2004 13:11:27 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 11F9D8C708; Wed, 11 Feb 2004 13:11:27 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 52 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-0.001, requis 5, BAYES_44 -0.00) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19867 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19867 > I've just installed a change that makes diff.el use diff-mode. > It considerably simplifies the code of diff.el while at the same time > bringing a whole bunch of improvements to diff.el. It's also part of the > effort to clear the way for the new compile.el. > Thank you. Note that it was mostly Daniel's work. Also using diff-mode implies that things work differently. I think the benefit is worth the cost. > I'm eager to see the new compile.el installed. Same here. > Daniel, what obstacles still remain? The only packages that might still suffer are tex-mode and ada-xref. The tex-mode part is code that works very poorly as it is, so I doubt people use it much. I expect most people who need such feature use AUCTeX instead, so I think it's OK to just junk it. We may be able to implement a better replacement afterwards using the new compile.el, actually. But I don't think this should stop us from installing the new compile.el. As for ada-xref.el, I'll let Daniel explain what might be broken, because I don't know. It's not even clear to me whether it would be broken or not. Also the ada-xref.el code does some really fishy things which might break other packages. See the example of code I appended. I think th best way to get this code working with the new compile.el is to install the new code and wait for someone to complain, because I don't know anyone who understands what bugs might be introduced. Once/if we have an actual bug-report we'll be better able to go about fixing things. Stefan ;; Temporarily replaces the definition of `comint-exec' so that we ;; can execute commands before running gdb. ;; FIXME: This is evil and not temporary !!! -stef (fset 'comint-exec `(lambda (buffer name command startfile switches) (let (compilation-buffer-name-function) (save-excursion (set 'compilation-buffer-name-function (lambda(x) (buffer-name buffer))) (compile (ada-quote-cmd (concat ,pre-cmd command " " (mapconcat 'identity switches " ")))))) ))