From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Faces applies to new frames Date: Thu, 26 Jun 2008 21:28:48 -0400 Message-ID: References: <87k5gbx12n.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214530146 8101 80.91.229.12 (27 Jun 2008 01:29:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Jun 2008 01:29:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 27 03:29:50 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KC2mb-0005MN-8o for ged-emacs-devel@m.gmane.org; Fri, 27 Jun 2008 03:29:49 +0200 Original-Received: from localhost ([127.0.0.1]:43487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KC2ll-0002XC-BW for ged-emacs-devel@m.gmane.org; Thu, 26 Jun 2008 21:28:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KC2lg-0002Wq-Qf for emacs-devel@gnu.org; Thu, 26 Jun 2008 21:28:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KC2le-0002VM-5n for emacs-devel@gnu.org; Thu, 26 Jun 2008 21:28:51 -0400 Original-Received: from [199.232.76.173] (port=47267 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KC2le-0002VF-2D for emacs-devel@gnu.org; Thu, 26 Jun 2008 21:28:50 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:28522 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KC2ld-0002J2-Qu for emacs-devel@gnu.org; Thu, 26 Jun 2008 21:28:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuAFAJreY0hFxIdG/2dsb2JhbACBW7IUgXA X-IronPort-AV: E=Sophos;i="4.27,712,1204520400"; d="scan'208";a="23260415" Original-Received: from 69-196-135-70.dsl.teksavvy.com (HELO pastel.home) ([69.196.135.70]) by ironport2-out.teksavvy.com with ESMTP; 26 Jun 2008 21:28:48 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 629DA801D; Thu, 26 Jun 2008 21:28:48 -0400 (EDT) In-Reply-To: <87k5gbx12n.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 26 Jun 2008 18:50:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99989 Archived-At: > AFAICT, the problem is that the default face is controlled by the `font' > frame parameter, but this is not saved to default-frame-alist by > internal-set-lisp-face-attribute. In comparison, the foreground-color I'm not convinced this is the root of the problem. For one, by default there is no `font' parameter in default-frame-alist, so as long as we leave it that way, it should not affect face settings. The code in face-set-after-frame-default should apply the defface-spec to every new frame, so we shouldn't need any entry in default-frame-alist for it to apply to new frames. The face-set-after-frame-default used to skip `default', so that was an important reason for the bug#47. I've fixed this part, but there are other weird things going on (I have some other weird problems here where X resources are obeyed even after I remove the calls to `make-face-x-resource-internal'). I think we need to write down every step of how faces are initialized for each frame (then lament the fact faces are the same on all frames in 99.99% of the cases), then how frame-parameters are treated, and then how they affect each other. Stefan