From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Faces applies to new frames Date: Sat, 28 Jun 2008 23:41:11 -0400 Message-ID: References: <87k5gbx12n.fsf@stupidchicken.com> <87iqvtgdmm.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214710895 3658 80.91.229.12 (29 Jun 2008 03:41:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Jun 2008 03:41:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 29 05:42:21 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KCnnv-0007bu-Ou for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 05:42:20 +0200 Original-Received: from localhost ([127.0.0.1]:52785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCnn5-000298-Ql for ged-emacs-devel@m.gmane.org; Sat, 28 Jun 2008 23:41:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KCnn1-000293-NG for emacs-devel@gnu.org; Sat, 28 Jun 2008 23:41:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KCnn0-00028r-LU for emacs-devel@gnu.org; Sat, 28 Jun 2008 23:41:23 -0400 Original-Received: from [199.232.76.173] (port=46085 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCnn0-00028o-IM for emacs-devel@gnu.org; Sat, 28 Jun 2008 23:41:22 -0400 Original-Received: from 69-196-135-70.dsl.teksavvy.com ([69.196.135.70]:54216 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KCnn0-0004pp-8C for emacs-devel@gnu.org; Sat, 28 Jun 2008 23:41:22 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4151070034; Sat, 28 Jun 2008 23:41:11 -0400 (EDT) In-Reply-To: <87iqvtgdmm.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 28 Jun 2008 22:48:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100115 Archived-At: > Regarding your recent change to face-set-after-frame-default: in the > loop that initializes faces from face specs and X resources, I believe > the reason this excluded the `default' face is that the `default' face's > attributes are supposed to be applied right at the beginning of > face-set-after-frame-default: > (if (face-attribute 'default :font t) > (set-face-attribute 'default frame :font > (face-attribute 'default :font t)) > (set-face-attribute 'default frame :family > (face-attribute 'default :family t)) > (set-face-attribute 'default frame :height > (face-attribute 'default :height t)) > .... I must say I don't know what the above is trying to do. > Thus, the function is simply trying to avoid doing the work twice. Not quite: the second part applies defface settings, whereas the first part applies "global face-attributes" (don't know why they weren't set already). Stefan