From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: system "key" events in NS port Date: Wed, 11 Mar 2009 10:27:36 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236782018 5491 80.91.229.12 (11 Mar 2009 14:33:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Mar 2009 14:33:38 +0000 (UTC) Cc: Emacs-Devel devel To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 11 15:34:52 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhPQl-0006Ld-Bh for ged-emacs-devel@m.gmane.org; Wed, 11 Mar 2009 15:29:11 +0100 Original-Received: from localhost ([127.0.0.1]:42472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhPPP-0006Rp-I5 for ged-emacs-devel@m.gmane.org; Wed, 11 Mar 2009 10:27:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhPPK-0006PC-K8 for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:27:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhPPI-0006Ns-6a for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:27:40 -0400 Original-Received: from [199.232.76.173] (port=53385 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhPPH-0006Ne-RE for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:27:39 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:27662 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhPPH-0002gJ-HZ for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:27:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlwFAE9nt0lFxL+1/2dsb2JhbACBTs9thA0GhDE X-IronPort-AV: E=Sophos;i="4.38,343,1233550800"; d="scan'208";a="35035414" Original-Received: from 69-196-191-181.dsl.teksavvy.com (HELO pastel.home) ([69.196.191.181]) by ironport2-out.teksavvy.com with ESMTP; 11 Mar 2009 10:27:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 210D38258; Wed, 11 Mar 2009 10:27:37 -0400 (EDT) In-Reply-To: (David Reitter's message of "Tue, 10 Mar 2009 23:18:03 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109564 Archived-At: > The events sent in the NS port to signal menu actions such as "Quit Emacs" > (application menu) are sent as NON_ASCII_KEYSTROKE_EVENTs, which lead to > last_nonmenu_event being set. This is unfortunate, because functions like > y-or-n-p depend on the variable to decide whether to show a graphical > dialog when the mouse was used. > The patch below has an #ifdef HAVE_NS, which can be removed should other > platforms exhibit the same problem. I think the right way to do it is to add a new event_kind rather than abuse `arg'. Stefan