From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3269: 23.0.93; C-mode text highlighting Date: Tue, 19 May 2009 10:36:05 -0400 Message-ID: References: <878wl1h5fw.fsf@ancient.thomaschristensen.org> <20090514213924.GB2413@muc.de> <20090518150643.GA12920@muc.de> <20090518213030.GD12920@muc.de> <20090519102619.GA1317@muc.de> Reply-To: Stefan Monnier , 3269@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242744758 29598 80.91.229.12 (19 May 2009 14:52:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 May 2009 14:52:38 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Chong Yidong , 3269@emacsbugs.donarmstrong.com, Thomas Christensen , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 19 16:52:30 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M6Qg7-0002Y0-GR for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 May 2009 16:52:27 +0200 Original-Received: from localhost ([127.0.0.1]:44242 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6Qg6-00085i-Pc for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 May 2009 10:52:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6Qfo-0007z6-OY for bug-gnu-emacs@gnu.org; Tue, 19 May 2009 10:52:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6Qfi-0007xR-VS for bug-gnu-emacs@gnu.org; Tue, 19 May 2009 10:52:07 -0400 Original-Received: from [199.232.76.173] (port=35230 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6Qfi-0007xM-Gf for bug-gnu-emacs@gnu.org; Tue, 19 May 2009 10:52:02 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43935) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M6Qfh-0004je-Rq for bug-gnu-emacs@gnu.org; Tue, 19 May 2009 10:52:02 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4JEpvGC014400; Tue, 19 May 2009 07:51:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4JEe771010239; Tue, 19 May 2009 07:40:07 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 19 May 2009 14:40:07 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3269 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3269-submit@emacsbugs.donarmstrong.com id=B3269.12427437179172 (code B ref 3269); Tue, 19 May 2009 14:40:07 +0000 Original-Received: (at 3269) by emacsbugs.donarmstrong.com; 19 May 2009 14:35:17 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4JEZ98H008659 for <3269@emacsbugs.donarmstrong.com>; Tue, 19 May 2009 07:35:11 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Al4FAOtgEkpMCovv/2dsb2JhbACBT84agkCBQgWFcA X-IronPort-AV: E=Sophos;i="4.41,215,1241409600"; d="scan'208";a="38759909" Original-Received: from 76-10-139-239.dsl.teksavvy.com (HELO pastel.home) ([76.10.139.239]) by ironport2-out.teksavvy.com with ESMTP; 19 May 2009 10:35:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 904797F29; Tue, 19 May 2009 10:36:05 -0400 (EDT) In-Reply-To: <20090519102619.GA1317@muc.de> (Alan Mackenzie's message of "Tue, 19 May 2009 10:26:19 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 19 May 2009 10:52:07 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28029 Archived-At: >> In other words, messed-up highlighting for incorrect code is just as >> good if not better than explicitly recognizing the incorrect code and >> highlighting it with f-l-warning-face. > I was thinking of "compatibility" with unterminated strings in normal > code. But they're not the same thing. An open string in a #define is > perfectly valid code, if somewhat unusual outside of the Obfuscated C > competition. > You've persuaded me that the existing fontification is actually better. > So I won't be committing yesterday's patch. Thanks! I'm glad we ended up agreeing, tho for completely different reasons. > I'll just finish the other patch and commit that. Thanks, Stefan