From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: bug#3269: 23.0.93; C-mode text highlighting Date: Tue, 19 May 2009 10:36:05 -0400 Message-ID: References: <878wl1h5fw.fsf@ancient.thomaschristensen.org> <20090514213924.GB2413@muc.de> <20090518150643.GA12920@muc.de> <20090518213030.GD12920@muc.de> <20090519102619.GA1317@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242743729 25878 80.91.229.12 (19 May 2009 14:35:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 May 2009 14:35:29 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Chong Yidong , 3269@emacsbugs.donarmstrong.com, Thomas Christensen , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 19 16:35:21 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M6QPW-0002oA-AI for ged-emacs-devel@m.gmane.org; Tue, 19 May 2009 16:35:18 +0200 Original-Received: from localhost ([127.0.0.1]:48627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6QPV-0002Np-I5 for ged-emacs-devel@m.gmane.org; Tue, 19 May 2009 10:35:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6QPR-0002NS-5k for emacs-devel@gnu.org; Tue, 19 May 2009 10:35:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6QPL-0002N7-2O for emacs-devel@gnu.org; Tue, 19 May 2009 10:35:11 -0400 Original-Received: from [199.232.76.173] (port=54044 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6QPK-0002N4-Tc for emacs-devel@gnu.org; Tue, 19 May 2009 10:35:06 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:17184 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M6QPJ-0001Hk-06; Tue, 19 May 2009 10:35:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Al4FAOtgEkpMCovv/2dsb2JhbACBT84agkCBQgWFcA X-IronPort-AV: E=Sophos;i="4.41,215,1241409600"; d="scan'208";a="38759909" Original-Received: from 76-10-139-239.dsl.teksavvy.com (HELO pastel.home) ([76.10.139.239]) by ironport2-out.teksavvy.com with ESMTP; 19 May 2009 10:35:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 904797F29; Tue, 19 May 2009 10:36:05 -0400 (EDT) In-Reply-To: <20090519102619.GA1317@muc.de> (Alan Mackenzie's message of "Tue, 19 May 2009 10:26:19 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110986 gmane.emacs.pretest.bugs:24472 Archived-At: >> In other words, messed-up highlighting for incorrect code is just as >> good if not better than explicitly recognizing the incorrect code and >> highlighting it with f-l-warning-face. > I was thinking of "compatibility" with unterminated strings in normal > code. But they're not the same thing. An open string in a #define is > perfectly valid code, if somewhat unusual outside of the Obfuscated C > competition. > You've persuaded me that the existing fontification is actually better. > So I won't be committing yesterday's patch. Thanks! I'm glad we ended up agreeing, tho for completely different reasons. > I'll just finish the other patch and commit that. Thanks, Stefan