From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: indirect threading for bytecode interpreter Date: Thu, 17 Sep 2009 14:21:08 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253211689 20609 80.91.229.12 (17 Sep 2009 18:21:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Sep 2009 18:21:29 +0000 (UTC) Cc: Emacs development discussions To: tromey@redhat.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 17 20:21:22 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MoLbb-0001Mf-Ky for ged-emacs-devel@m.gmane.org; Thu, 17 Sep 2009 20:21:19 +0200 Original-Received: from localhost ([127.0.0.1]:41456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoLbb-0000Y3-2i for ged-emacs-devel@m.gmane.org; Thu, 17 Sep 2009 14:21:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoLbX-0000XS-PI for emacs-devel@gnu.org; Thu, 17 Sep 2009 14:21:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoLbS-0000W5-7W for emacs-devel@gnu.org; Thu, 17 Sep 2009 14:21:14 -0400 Original-Received: from [199.232.76.173] (port=39244 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoLbS-0000W2-4u for emacs-devel@gnu.org; Thu, 17 Sep 2009 14:21:10 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:56950) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoLbR-0003Lz-JP for emacs-devel@gnu.org; Thu, 17 Sep 2009 14:21:09 -0400 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n8HIL80x020671; Thu, 17 Sep 2009 14:21:08 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 6A6213A104; Thu, 17 Sep 2009 14:21:08 -0400 (EDT) In-Reply-To: (Tom Tromey's message of "Thu, 17 Sep 2009 10:46:44 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3365=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115423 Archived-At: > This patch implements indirect threading for the Emacs bytecode > interpreter. It uses a GNU C extension, and falls back to the current > switch-based code if Emacs is compiled with some other compiler. Looks good, thank you. I'd prefer a rewrite of bytecode.c using vmgen, since it should make the code (c)leaner (and eliminate the risk of inconsistency between different parts of the code, like your sanity checks implement). But it's a good change. I'd rather wait a little bit before installing it, tho: there's a chance we may be able to switch to Bzr fairly soon, in which case I think I'll prefer to install it in the Emacs-24 branch. Stefan