From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Patch to make vc-hg.el work with remote files Date: Tue, 27 Oct 2009 22:07:56 -0400 Message-ID: References: <200910251856.04156.bernhard.herzog@intevation.de> <200910271301.24348.bernhard.herzog@intevation.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1256695696 28628 80.91.229.12 (28 Oct 2009 02:08:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Oct 2009 02:08:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bernhard Herzog Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 28 03:08:09 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N2xxI-00040V-Ii for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2009 03:08:09 +0100 Original-Received: from localhost ([127.0.0.1]:49524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2xxH-0004IJ-T5 for ged-emacs-devel@m.gmane.org; Tue, 27 Oct 2009 22:08:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2xxC-0004Hy-D4 for emacs-devel@gnu.org; Tue, 27 Oct 2009 22:08:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2xx7-0004FX-JT for emacs-devel@gnu.org; Tue, 27 Oct 2009 22:08:01 -0400 Original-Received: from [199.232.76.173] (port=52285 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2xx7-0004FP-E9 for emacs-devel@gnu.org; Tue, 27 Oct 2009 22:07:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:54875 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2xx7-0005D4-1l for emacs-devel@gnu.org; Tue, 27 Oct 2009 22:07:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArwEAGBE50pLd/xb/2dsb2JhbACBUNhNhD8EiDw X-IronPort-AV: E=Sophos;i="4.44,636,1249272000"; d="scan'208";a="48276716" Original-Received: from 75-119-252-91.dsl.teksavvy.com (HELO ceviche.home) ([75.119.252.91]) by ironport2-out.pppoe.ca with ESMTP; 27 Oct 2009 22:07:56 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3463670019; Tue, 27 Oct 2009 22:07:56 -0400 (EDT) In-Reply-To: <200910271301.24348.bernhard.herzog@intevation.de> (Bernhard Herzog's message of "Tue, 27 Oct 2009 13:01:24 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116431 Archived-At: > Indeed. Here's a new patch. Thanks, installed. But I wonder about the last hunk of your patch: > @@ -286,7 +288,6 @@ > (setq oldvers working)) > (apply #'vc-hg-command (or buffer "*vc-diff*") nil > (mapcar (lambda (file) (file-relative-name file cwd)) files) > - "--cwd" cwd > "diff" > (append > (vc-switches 'hg 'diff) What is the reason for it? Stefan