From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix for vc-bzr-diff when vc-bzr-diff-switches is t Date: Thu, 27 Jan 2011 12:19:23 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296149388 12624 80.91.229.12 (27 Jan 2011 17:29:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 27 Jan 2011 17:29:48 +0000 (UTC) Cc: Emacs-Devel devel To: Deniz Dogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 27 18:29:44 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PiVf5-0007Fu-1T for ged-emacs-devel@m.gmane.org; Thu, 27 Jan 2011 18:29:35 +0100 Original-Received: from localhost ([127.0.0.1]:48796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiVVM-0006Cm-P3 for ged-emacs-devel@m.gmane.org; Thu, 27 Jan 2011 12:19:32 -0500 Original-Received: from [140.186.70.92] (port=53549 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiVVG-00064f-Jn for emacs-devel@gnu.org; Thu, 27 Jan 2011 12:19:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PiVVF-0006qj-0q for emacs-devel@gnu.org; Thu, 27 Jan 2011 12:19:26 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:5907 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PiVVE-0006qN-UQ for emacs-devel@gnu.org; Thu, 27 Jan 2011 12:19:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAJc3QU1FpZU//2dsb2JhbACkfHS8C4VPBIUXj2k X-IronPort-AV: E=Sophos;i="4.60,386,1291611600"; d="scan'208";a="89435390" Original-Received: from 69-165-149-63.dsl.teksavvy.com (HELO pastel.home) ([69.165.149.63]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 27 Jan 2011 12:19:23 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8D15D58C4E; Thu, 27 Jan 2011 12:19:23 -0500 (EST) In-Reply-To: (Deniz Dogan's message of "Thu, 27 Jan 2011 10:50:49 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135114 Archived-At: > Here is my third attempt given your comments. Looks good, please apply. > + * vc/vc-bzr.el (vc-bzr-diff): Don't pass --diff-options unless > + there are any diff switches. IIRC in such positive sentences, you want to use "some" rather than "any". Stefan