From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: M-y in isearch mode Date: Mon, 02 May 2011 15:16:21 -0300 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304360193 2927 80.91.229.12 (2 May 2011 18:16:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 2 May 2011 18:16:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 02 20:16:29 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QGxfY-0005Ic-HK for ged-emacs-devel@m.gmane.org; Mon, 02 May 2011 20:16:28 +0200 Original-Received: from localhost ([::1]:54485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGxfY-0006YS-21 for ged-emacs-devel@m.gmane.org; Mon, 02 May 2011 14:16:28 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGxfV-0006Y9-2r for emacs-devel@gnu.org; Mon, 02 May 2011 14:16:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QGxfU-0002Sg-3A for emacs-devel@gnu.org; Mon, 02 May 2011 14:16:25 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:36240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGxfT-0002Sc-UM for emacs-devel@gnu.org; Mon, 02 May 2011 14:16:24 -0400 Original-Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:54717 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QGxfT-0007Sp-HF; Mon, 02 May 2011 14:16:23 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 9EB2D66119; Mon, 2 May 2011 15:16:21 -0300 (ART) In-Reply-To: (Leo's message of "Tue, 03 May 2011 00:51:28 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138973 Archived-At: > Sounds good. Patch modified to this suggestion. Fell free to commit. > +(defun isearch-yank-pop () > + "Replace just-yanked search string with previously killed string." > + (interactive) > + (if (not (memq last-command '(isearch-yank-kill isearch-yank-pop))) > + (isearch-yank-kill) You can add a short comment here explaining why we do this fallback (and we may want to change this fallback in the future if we ever change yank-pop to do something like the kill-ring-browser). Stefan