From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: 5x5 Arithmetic solver Date: Sat, 21 May 2011 20:29:11 -0300 Message-ID: References: <80r57s4j82.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1306020574 27043 80.91.229.12 (21 May 2011 23:29:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 21 May 2011 23:29:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Vincent =?iso-8859-1?Q?Bela=EFche?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 22 01:29:27 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QNvbq-0000IQ-SU for ged-emacs-devel@m.gmane.org; Sun, 22 May 2011 01:29:27 +0200 Original-Received: from localhost ([::1]:52895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNvbq-000891-5J for ged-emacs-devel@m.gmane.org; Sat, 21 May 2011 19:29:26 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNvbn-00088w-RA for emacs-devel@gnu.org; Sat, 21 May 2011 19:29:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNvbm-0000ZI-VH for emacs-devel@gnu.org; Sat, 21 May 2011 19:29:23 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:43721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNvbm-0000ZE-Tj for emacs-devel@gnu.org; Sat, 21 May 2011 19:29:22 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:43422 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QNvbm-0004N0-Bd; Sat, 21 May 2011 19:29:22 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id CCCBB66131; Sat, 21 May 2011 20:29:11 -0300 (ART) In-Reply-To: <80r57s4j82.fsf@gmail.com> ("Vincent =?iso-8859-1?Q?Bela=EFch?= =?iso-8859-1?Q?e=22's?= message of "Sat, 21 May 2011 09:15:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139611 Archived-At: >> - why 5x5-local-variables? > That is used in 5x5-mode to imply that all listed variable are made > local to that very 5x5 buffer. if after `M-x 5x5' you do a `M-x > rename-uniquely' and then `M-x 5x5' again then you have have two > independent games. So those vars should always be buffer-local and it's a property of those vars, rather than some kind of "configuration", so just add (make-variable-buffer-local ') after each one of those variables. >> - explain the changes in the 5x5 function. > I had to change slightly the order of operations because setting the > mode has to be done before any buffer local 5x5 variable is touched, as > precisely those variables are made local by setting the mode I see, thanks. >> - stay within 80 columns. > Do you mean that we are still in the 80ies ;-P ?=20 Yup, humans's reading abilities are still the same as in the 80ies, sadly. >> - try C-u checkdoc-current-buffer. ^^^ C-x M-x > I get=20 > checkdoc-continue: Too many occurrences of \[function]. Use \{keymap} > instead > Because 5x5 is used many times as if it was=20 Yes, the original code already raised some flags. It's OK, these are guidelines, which like all rules need to be broken every once in a while. > ----------------------------------------------------------------------- > 2011-05-21 Vincent Bela=EFche > * play/5x5.el: Add an arithmetic solver to suggest positions to > click on. The ChangeLog comment should be more detailed, see the megabytes of ChangeLog in Emacs as examples, as well as http://www.gnu.org/prep/standards/html_node/Change-Logs.html. The ChangeLog should at the very least answer the questions I asked and mention all the functions that are modified/added/removed. >> - I don't understand the "solve step" message (e.g. it said 23 every >> time, even though I followed its suggestions and finished in 12 moves). > Ask it to Jay, this message is output by Calc, not by 5x5. 23 is due > to this that you have to invert a 23x23 matrix. Altough the 5x5 transfer > matrix is 25x25, its rank is only 23, so I extract some submatrix to > compute the solution. I see. Short of changing Calc, you could add your own `message' after the call to Calc that produces those messages, so it's a bit more clear that these are intermediate messages not pertaining to the final answer. Stefan