From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 9796@debbugs.gnu.org
Subject: bug#9796: 24.0.90; Major mode selection after "save as"
Date: Fri, 21 Oct 2011 08:52:15 -0400 [thread overview]
Message-ID: <jwvd3dqh5me.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <64y5we3m4t.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 21 Oct 2011 02:16:18 -0400")
>>> set-auto-mode is being used here though, not normal-mode.
>> So I guess we shouldn't use set-auto-mode here.
> normal-mode first switches to fundamental-mode, then changes to the
> right mode, then turns font-lock off and on. Is that necessary here?
> Also it does not have a "keep-mode-if-same" argument.
> It seems simpler to me for set-visited-file-name just to
> hack-local-variables.
For 24.1, yes. But in general we'd want to restructure the code a bit
to make it harder to avoid running hack-local-variables-hook (or maybe
provide a new hook to replace it, which is guaranteed to run after
changing a major-mode).
Stefan
next prev parent reply other threads:[~2011-10-21 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 16:05 bug#9796: 24.0.90; Mayor mode selection after "save as" Dani Moncayo
2011-10-19 17:09 ` bug#9796: 24.0.90; Major " Dani Moncayo
2011-10-19 21:43 ` Glenn Morris
2011-10-19 21:51 ` Glenn Morris
2011-10-20 0:30 ` Stefan Monnier
2011-10-20 1:26 ` Glenn Morris
2011-10-20 2:23 ` Stefan Monnier
2011-10-21 6:16 ` Glenn Morris
2011-10-21 12:52 ` Stefan Monnier [this message]
2011-10-27 6:38 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd3dqh5me.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9796@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.