From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Changes in revision 106420 reverted Date: Sat, 19 Nov 2011 08:55:06 -0500 Message-ID: References: <83pqgobitt.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321710919 19587 80.91.229.12 (19 Nov 2011 13:55:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Nov 2011 13:55:19 +0000 (UTC) Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 19 14:55:15 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRlNy-0004DV-Iy for ged-emacs-devel@m.gmane.org; Sat, 19 Nov 2011 14:55:14 +0100 Original-Received: from localhost ([::1]:51768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRlNx-0000lH-5i for ged-emacs-devel@m.gmane.org; Sat, 19 Nov 2011 08:55:13 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:39847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRlNu-0000lC-WF for emacs-devel@gnu.org; Sat, 19 Nov 2011 08:55:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRlNu-0004nD-7R for emacs-devel@gnu.org; Sat, 19 Nov 2011 08:55:10 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:16969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRlNt-0004m0-1X; Sat, 19 Nov 2011 08:55:09 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAPezx05MCo1P/2dsb2JhbABEqj6BBoFyAQEEAVYjBQsLNBIUGA0kiBa1UooXBIgamXqESw X-IronPort-AV: E=Sophos;i="4.69,538,1315195200"; d="scan'208";a="148593039" Original-Received: from 76-10-141-79.dsl.teksavvy.com (HELO pastel.home) ([76.10.141.79]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Nov 2011 08:55:06 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 225435936F; Sat, 19 Nov 2011 08:55:06 -0500 (EST) In-Reply-To: <83pqgobitt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Nov 2011 10:46:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146096 Archived-At: > Besides, code like this: > #if !XASSERTS > static > #endif > unsigned > row_hash (struct glyph_row *row) > { > is butt-ugly, IMNSHO. There's a limit to which we should go to pacify > overly-pedantic compiler switches, and this is way out. Agreed, thank you, Stefan