all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: Changes in revision 106420 reverted
Date: Sat, 19 Nov 2011 08:55:06 -0500	[thread overview]
Message-ID: <jwvd3co1al0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83pqgobitt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Nov 2011 10:46:38 +0200")

> Besides, code like this:

>  #if !XASSERTS
>  static
>  #endif
>  unsigned
>  row_hash (struct glyph_row *row)
>  {

> is butt-ugly, IMNSHO.  There's a limit to which we should go to pacify
> overly-pedantic compiler switches, and this is way out.

Agreed, thank you,


        Stefan



      reply	other threads:[~2011-11-19 13:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-19  8:46 Changes in revision 106420 reverted Eli Zaretskii
2011-11-19 13:55 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd3co1al0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.