From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10289: 24.0.92; Sneaky clobbering of user key binding Date: Tue, 13 Dec 2011 14:38:24 -0500 Message-ID: References: <87iplkmrce.fsf@escher.fritz.box> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: dough.gmane.org 1323805195 19605 80.91.229.12 (13 Dec 2011 19:39:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2011 19:39:55 +0000 (UTC) Cc: 10289@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 13 20:39:50 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RaYCa-0003l9-4d for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Dec 2011 20:39:48 +0100 Original-Received: from localhost ([::1]:38217 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaYCZ-0002mG-MO for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Dec 2011 14:39:47 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:40877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaYCW-0002m0-OI for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2011 14:39:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaYCV-00034z-NV for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2011 14:39:44 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaYCV-00034v-Lw for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2011 14:39:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RaYDm-0003kW-Ii for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2011 14:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2011 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10289-submit@debbugs.gnu.org id=B10289.132380521314349 (code B ref 10289); Tue, 13 Dec 2011 19:41:02 +0000 Original-Received: (at 10289) by debbugs.gnu.org; 13 Dec 2011 19:40:13 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RaYCy-0003jO-R1 for submit@debbugs.gnu.org; Tue, 13 Dec 2011 14:40:13 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RaYCt-0003j9-Vw for 10289@debbugs.gnu.org; Tue, 13 Dec 2011 14:40:08 -0500 Original-Received: from ceviche.home ([173.176.12.77]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0LW500EBXQK20G30@VL-VM-MR006.ip.videotron.ca> for 10289@debbugs.gnu.org; Tue, 13 Dec 2011 14:38:28 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id 2BC5F662EE; Tue, 13 Dec 2011 14:38:24 -0500 (EST) In-reply-to: <87iplkmrce.fsf@escher.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 13 Dec 2011 14:41:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54929 Archived-At: > I think it's a bug to clobber a user setting in this sneaky way: I don't Agreed. > I think the best solution to this problem from the user's POV would be There indeed various ways to solve this problem. One convention which Emacs mandates (but doesn't enforce, obviously) is that loading a file should not have any other (visible) side effect than providing new behavior (e.g. defining new commands and variables) without affecting existing behavior. Obviously it's a fuzzy convention, but from this point of view, the problem is that loading Org (well, one of its files) changed the calendar keymap. > perhaps by unloading the libraries after the processing (unless they That's pretty much impossible to do reliably given the way Elisp works right now (it's not sufficiently declarative for that). > throttle Emacs too much? If so, a less desirable solution could be for > defcustoms like org-calendar-agenda-action-key to check whether the key > is bound and in that case require (as nonintrusively as possible) user > intervention. I think a good solution should be along these lines: only add the `k' binding if the `k' key is currently "unbound" (or more generally does nothing more than signal an error, since `k' is probably bound to something like `undefined'). Of course, this care should only be used if org-calendar-agenda-action-key was not set explicitly by the user. Stefan