From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 13 Jan 2012 14:43:43 -0500 Message-ID: References: <87mx9su32g.fsf@web.de> <87sjjkfvwt.fsf@gmail.com> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326483883 614 80.91.229.12 (13 Jan 2012 19:44:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 Jan 2012 19:44:43 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 13 20:44:39 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rln3E-00076e-2Z for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 20:44:36 +0100 Original-Received: from localhost ([::1]:59285 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rln3D-0004zF-IO for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 14:44:35 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:52318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rln3B-0004yu-CC for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 14:44:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rln32-0003wU-5L for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 14:44:33 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rln32-0003wK-1G for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 14:44:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rln3d-00034e-Rr for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 14:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jan 2012 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132648386811738 (code B ref 10489); Fri, 13 Jan 2012 19:45:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 13 Jan 2012 19:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:56760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rln36-00033H-6y for submit@debbugs.gnu.org; Fri, 13 Jan 2012 14:44:28 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:4539) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rln31-000337-5E for 10489@debbugs.gnu.org; Fri, 13 Jan 2012 14:44:26 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EAL6IEE9FxKkV/2dsb2JhbABCqnmCM4EGgXIBAQQBViMFCws0EhQYDSSIDbZ+jB0EiDyaYYRS X-IronPort-AV: E=Sophos;i="4.71,506,1320642000"; d="scan'208";a="156639782" Original-Received: from 69-196-169-21.dsl.teksavvy.com (HELO pastel.home) ([69.196.169.21]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jan 2012 14:43:43 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3E7DF59439; Fri, 13 Jan 2012 14:43:43 -0500 (EST) In-Reply-To: <8739bj8mu1.fsf@gmail.com> (Thierry Volpiatto's message of "Fri, 13 Jan 2012 19:43:50 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55714 Archived-At: > What about this? > (defun file-name-equal-p (name1 name2 &optional dir) > (let* ((n1 (file-truename (expand-file-name name1 dir))) There's a crucial line missing between the above two. It should clearly document what this function is expected to do. E.g. it should make it clear if (and if so, to what extent) the function is allowed to refer to the actual file system(s) as opposed to only relying on the provided strings. Stefan