From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tom Tromey <tromey@redhat.com>
Cc: Emacs discussions <emacs-devel@gnu.org>
Subject: Re: [PATCH 01/10] move some globals into a thread object
Date: Thu, 09 Aug 2012 21:18:58 -0400 [thread overview]
Message-ID: <jwvd32z7dh0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87vcgreu1s.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 09 Aug 2012 13:37:03 -0600")
> The #defines mean that this patch also has to rename a few fields
> whose names clash with the defines.
I'd rather rename the globals (although I understand it will probably
result in a larger patch), because I'd rather limit the impact of those
#defines. If you ever create a local variable (or a struct field) named
`current_buffer' somewhere, it might take you a good while to figure out
why your code is misbehaving.
Stefan
next prev parent reply other threads:[~2012-08-10 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 19:37 [PATCH 01/10] move some globals into a thread object Tom Tromey
2012-08-10 1:18 ` Stefan Monnier [this message]
2012-08-13 14:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd32z7dh0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.