From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
12215@debbugs.gnu.org, Dmitry Antipov <dmantipov@yandex.ru>
Subject: bug#12215: CSET is unnecessarily confusing
Date: Fri, 24 Aug 2012 11:10:02 -0400 [thread overview]
Message-ID: <jwvd32gs5ay.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fw7d3qan.fsf@gnu.org> (Chong Yidong's message of "Fri, 24 Aug 2012 11:46:40 +0800")
Paul Eggert said:
> If that flag has a standard name, one doesn't need separate macros
> BSET/CSET/etc; one can have just one macro that works for all types.
Indeed. Tho, since we haven't managed yet to do that for gcmarkbit, I'm
not holding my breath.
Chong Yidong said:
> BVAR (b->directory) = current_buffer ? BVAR
> (current_buffer->directory) : Qnil;
The BVAR accessor macro is not for the GC but for the concurrency code.
And yes, I think that BVAR(foo->bar) can be sufficient for the
concurrency code (it can be macro-expanded to buffer_var(foo->bar,
current_thread)), assuming we change all buffer slots to be of a new
type, which is a table from thread_ids to Lisp_Object.
And even if it can't be done with a macro (because we want to use
another implementation technique that needs to look up some other data
in the buffer or to know the offset of the field), having those BVAR
will make it easy to replace those accessors with something else.
For the setters, I think we'll be better off with either
BSET (b->directory, val), or BSET (b, ->directory, val), which restricts
the form that can be used.
Stefan
next prev parent reply other threads:[~2012-08-24 15:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 0:04 bug#12215: CSET is unnecessarily confusing Paul Eggert
2012-08-17 4:12 ` Dmitry Antipov
2012-08-21 16:55 ` Stefan Monnier
2012-08-22 3:25 ` Paul Eggert
2012-08-22 13:27 ` Stefan Monnier
2012-08-22 16:35 ` Paul Eggert
2012-08-22 16:50 ` Dmitry Antipov
2012-08-23 7:02 ` Paul Eggert
2012-08-23 12:26 ` Stefan Monnier
2012-08-23 14:40 ` Paul Eggert
2012-08-24 3:46 ` Chong Yidong
2012-08-24 3:57 ` Paul Eggert
2012-08-24 4:26 ` Dmitry Antipov
2012-08-24 15:10 ` Stefan Monnier [this message]
2012-08-24 17:19 ` Paul Eggert
2012-08-24 17:27 ` Tom Tromey
2012-08-24 18:11 ` Paul Eggert
2012-08-24 21:12 ` Stefan Monnier
2012-08-25 0:17 ` Paul Eggert
2012-08-25 1:58 ` Stefan Monnier
2012-08-26 5:05 ` Paul Eggert
2012-08-21 17:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd32gs5ay.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12215@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.