From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14061: 24.3.50; Globbing in completion not working correctly Date: Wed, 27 Mar 2013 10:41:21 -0400 Message-ID: References: <87ip4dg53q.fsf@web.de> <87ip4disco.fsf@web.de> <87ehf1imkd.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364395306 22386 80.91.229.3 (27 Mar 2013 14:41:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Mar 2013 14:41:46 +0000 (UTC) Cc: 14061-done@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 27 15:42:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKrYJ-0007ld-66 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Mar 2013 15:42:11 +0100 Original-Received: from localhost ([::1]:41856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKrXv-0001nd-7b for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Mar 2013 10:41:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKrXn-0001fU-C9 for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 10:41:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKrXl-00067b-U4 for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 10:41:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKrXl-00067T-RA for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 10:41:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UKra6-0008G9-9b for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 10:44:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2013 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 14061@debbugs.gnu.org, monnier@iro.umontreal.ca, michael_heerdegen@web.de Original-Received: via spool by 14061-done@debbugs.gnu.org id=D14061.136439543031719 (code D ref 14061); Wed, 27 Mar 2013 14:44:01 +0000 Original-Received: (at 14061-done) by debbugs.gnu.org; 27 Mar 2013 14:43:50 +0000 Original-Received: from localhost ([127.0.0.1]:47637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKrZt-0008FX-E0 for submit@debbugs.gnu.org; Wed, 27 Mar 2013 10:43:49 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:43837) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKrZs-0008FO-0h for 14061-done@debbugs.gnu.org; Wed, 27 Mar 2013 10:43:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLSu/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLY0Zg3EDpHqBXoMTgUo X-IPAS-Result: Av8EABK/CFFFxLSu/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLY0Zg3EDpHqBXoMTgUo X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="5905054" Original-Received: from 69-196-180-174.dsl.teksavvy.com (HELO ceviche.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Mar 2013 10:41:19 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 623EA66152; Wed, 27 Mar 2013 10:41:21 -0400 (EDT) In-Reply-To: <87ehf1imkd.fsf@web.de> (Michael Heerdegen's message of "Wed, 27 Mar 2013 03:49:38 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72939 Archived-At: > Dunno what a good fix would look like. It tried > (let* ((pre-length (length prefix)) > (suffix (completion--common-suffix > (mapcar (lambda (comp) (substring comp pre-length)) > comps)))) > (cl-assert (stringp suffix)) > (unless (equal suffix "") > (push suffix res))) > which seems to work, but my insight in this code is limited. You were right on the money. I installed a slightly refined fix, which tries to optimize away a few cases. Thank you, Stefan