From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14202: 24.3.50; add-function doesn't check properly for existing advices with same name prop Date: Mon, 15 Apr 2013 11:07:26 -0400 Message-ID: References: <878v4ls12i.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1366038482 5853 80.91.229.3 (15 Apr 2013 15:08:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Apr 2013 15:08:02 +0000 (UTC) Cc: 14202-done@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 17:08:02 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1URl0j-0004wT-Nh for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2013 17:08:01 +0200 Original-Received: from localhost ([::1]:45482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URl0j-0001oC-8g for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2013 11:08:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URl0a-0001iJ-CM for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2013 11:07:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URl0Z-0002hi-5G for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2013 11:07:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URl0Z-0002hZ-1u for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2013 11:07:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1URl4c-0005V7-Ob for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2013 11:12:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2013 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 14202@debbugs.gnu.org, monnier@iro.umontreal.ca, michael_heerdegen@web.de Original-Received: via spool by 14202-done@debbugs.gnu.org id=D14202.136603870221101 (code D ref 14202); Mon, 15 Apr 2013 15:12:02 +0000 Original-Received: (at 14202-done) by debbugs.gnu.org; 15 Apr 2013 15:11:42 +0000 Original-Received: from localhost ([127.0.0.1]:52515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1URl4H-0005UH-Fw for submit@debbugs.gnu.org; Mon, 15 Apr 2013 11:11:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:64971) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1URl4G-0005UA-3g for 14202-done@debbugs.gnu.org; Mon, 15 Apr 2013 11:11:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxIEd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0BwsUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFFxIEd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0BwsUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="7441650" Original-Received: from 69-196-129-29.dsl.teksavvy.com (HELO pastel.home) ([69.196.129.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 Apr 2013 11:07:23 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id D962C67912; Mon, 15 Apr 2013 11:07:26 -0400 (EDT) In-Reply-To: <878v4ls12i.fsf@web.de> (Michael Heerdegen's message of "Sun, 14 Apr 2013 15:18:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73429 Archived-At: > Looks like `advice--member-p' is not DTRT: > When adding the advice the second time, this test > (equal function (cdr (assq 'name (advice--props definition)))) > seems to be "responsible". But it returns nil, because `function' is > bound to a byte code function, while Duh! Indeed that code was confused. Should be fixed now. Thank you, Stefan