From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 14202-done@debbugs.gnu.org
Subject: bug#14202: 24.3.50; add-function doesn't check properly for existing advices with same name prop
Date: Mon, 15 Apr 2013 11:07:26 -0400 [thread overview]
Message-ID: <jwvd2tvdeur.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878v4ls12i.fsf@web.de> (Michael Heerdegen's message of "Sun, 14 Apr 2013 15:18:13 +0200")
> Looks like `advice--member-p' is not DTRT:
> When adding the advice the second time, this test
> (equal function (cdr (assq 'name (advice--props definition))))
> seems to be "responsible". But it returns nil, because `function' is
> bound to a byte code function, while
Duh! Indeed that code was confused. Should be fixed now.
Thank you,
Stefan
prev parent reply other threads:[~2013-04-15 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 13:18 bug#14202: 24.3.50; add-function doesn't check properly for existing advices with same name prop Michael Heerdegen
2013-04-15 15:07 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd2tvdeur.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14202-done@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.