Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Stefan Monnier]

> +(defun shr-mouse-browse-url (ev)
> +  "Browse the URL under the mouse cursor."
> +  (interactive "e")
> +  (mouse-set-point ev)
> +  (shr-browse-url))

You can make that work for RET as well (by using (list
last-nonmenu-event) instead of "e", IIRC), so you don't need a separate
command for mouse events.


        Stefan

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> +(defun shr-mouse-browse-url (ev)
>> +  "Browse the URL under the mouse cursor."
>> +  (interactive "e")
>> +  (mouse-set-point ev)
>> +  (shr-browse-url))
>
> You can make that work for RET as well (by using (list
> last-nonmenu-event) instead of "e", IIRC), so you don't need a separate
> command for mouse events.

Hm.  I don't quite follow.  The command it calls reads stuff under
point, so we need the event (to change point) in the mousey command, but
not in the non-mousey command:

(defun shr-browse-url (&optional external)
  "Browse the URL under point.
If EXTERNAL, browse the URL using `shr-external-browser'."
  (interactive "P")
  (let ((url (get-text-property (point) 'shr-url)))


-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Jambunathan K]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Hm.  I don't quite follow.

I shared a tip that works.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Lars Magne Ingebrigtsen]

Jambunathan K <kjambunathan@gmail.com> writes:

> I shared a tip that works.

Where?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Glenn Morris]

Lars Magne Ingebrigtsen wrote:

> Jambunathan K <kjambunathan@gmail.com> writes:
>
>> I shared a tip that works.
>
> Where?

I'd ignore code suggestions from him if I were you.
They can't be used due to assignment issues.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Jambunathan K]

Glenn Morris <rgm@gnu.org> writes:

> Lars Magne Ingebrigtsen wrote:
>
>> Jambunathan K <kjambunathan@gmail.com> writes:
>>
>>> I shared a tip that works.
>>
>> Where?
>
> I'd ignore code suggestions from him if I were you.
> They can't be used due to assignment issues.

What code suggestions?  There was a suggestion but there wasn't a code
accompanying it (for a reason).

A suggestion that is NOT accompanied by a code, will that fall in the
domain of "copyright assignments"?  I am willing to learn.

ps: If you have issues with me appearing on this list or any of the
Emcacs lists, you can always censor my posts - much the same way what
the Org-mode folks are doing right now.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Eli Zaretskii]

> From: Jambunathan K <kjambunathan@gmail.com>
> Date: Tue, 30 Jul 2013 22:15:26 +0530
> Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
> 
> ps: If you have issues with me appearing on this list or any of the
> Emcacs lists, you can always censor my posts

As long as you are on-topic and civilized enough, that won't happen.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Jambunathan K]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jambunathan K <kjambunathan@gmail.com>
>> Date: Tue, 30 Jul 2013 22:15:26 +0530
>> Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
>> 
>> ps: If you have issues with me appearing on this list or any of the
>> Emcacs lists, you can always censor my posts
>
> As long as you are on-topic and civilized enough, that won't happen.

If people treat me well, I will be civil.  I will not talk about Bastien
or his brand of historical revisionism or fixing copyright headers -
like re-arranging authors - in subtle ways.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Juanma Barranquero]

On Tue, Jul 30, 2013 at 7:11 PM, Jambunathan K <kjambunathan@gmail.com> wrote:

> I will not talk about Bastien
> or his brand of historical revisionism or fixing copyright headers -
> like re-arranging authors - in subtle ways.

Certainly, that wasn't subtle.

   J

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Jambunathan K]

Juanma Barranquero <lekktu@gmail.com> writes:

> On Tue, Jul 30, 2013 at 7:11 PM, Jambunathan K <kjambunathan@gmail.com> wrote:
>
>> I will not talk about Bastien
>> or his brand of historical revisionism or fixing copyright headers -
>> like re-arranging authors - in subtle ways.
>
> Certainly, that wasn't subtle.

You need a smart quip in return?  Nah, I will just disappoint you.

>    J

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Stephen J. Turnbull]

Jambunathan K writes:

 > A suggestion that is NOT accompanied by a code, will that fall in the
 > domain of "copyright assignments"?

Sure.  Any suggestion that would result in changing the expressive
structure of Emacs source code could create a copyright.  I'm not sure
how closely you'd have to cooperate with the person who actually made
the changes to be considered to have copyright, but there's nothing in
the law that says you have to do any typing to get copyright.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Jambunathan K]

"Stephen J. Turnbull" <stephen@xemacs.org> writes:

> Any suggestion that would result in changing the expressive structure
> of Emacs source code could create a copyright.

The expressive structure of the stuff contributed by me to Emacs proper
is to a large extent dictated by mom and my SO.  I will have them sign
copyright assignments, *if* I start contributing to Emacs proper again.
Just to make sure that Emacs is safe and compliant with no
infringements.

Hopefully, FSF will send me stickers to compensate for money that I
spend on postal stamps.  I also hope that FSF staff will have the
politeness to return queries sent by a contributor.

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Stefan Monnier]

Nice weather today, eh?


        Stefan

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Nice weather today, eh?
>
>         Stefan

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Stefan Monnier]

> Hm.  I don't quite follow.  The command it calls reads stuff under
> point, so we need the event (to change point) in the mousey command, but
> not in the non-mousey command:

"Change point to the event" will also work for non-mouse events (it
will simply leave point where it is).


        Stefan

Re: [Emacs-diffs] trunk r113464: * net/shr.el (shr-mouse-browse-url): New command and keystroke.

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> "Change point to the event" will also work for non-mouse events (it
> will simply leave point where it is).

I see.  I've now made this change.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/