From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114390: * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros. Date: Thu, 19 Sep 2013 17:34:30 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1380057090 20455 80.91.229.3 (24 Sep 2013 21:11:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Sep 2013 21:11:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 24 23:11:28 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOZtF-0002g1-B8 for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2013 23:11:25 +0200 Original-Received: from localhost ([::1]:48231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOZtE-0001Gi-QU for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2013 17:11:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOZt4-0001GU-Gg for emacs-devel@gnu.org; Tue, 24 Sep 2013 17:11:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOZsx-0002xl-5r for emacs-devel@gnu.org; Tue, 24 Sep 2013 17:11:14 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:47521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOZsx-0002xg-1y; Tue, 24 Sep 2013 17:11:07 -0400 Original-Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MTN00CIFEUHHP60@VL-VM-MR006.ip.videotron.ca>; Tue, 24 Sep 2013 17:11:06 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id 27EEE66651; Thu, 19 Sep 2013 17:34:30 -0400 (EDT) In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163623 Archived-At: >>> + * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros. >> Why not? > Because it didn't work. > (defvar foo-var 0) > (defmacro foo-mac () > '(setq foo-var (1+ foo-var))) > (define-obsolete-function-alias 'old-mac #'foo-mac "24.4") > (defun foo-fails () > (old-mac)) > (defun foo-works () > (foo-mac)) Oh, I see. We should probably fix this, but in any case the code after define-obsolete-function-alias should be changed to use new-mac rather than old-mac. Stefan