From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Date: Tue, 29 Oct 2013 22:11:49 -0400 Message-ID: References: <87iowg9bqw.fsf@floss.red-bean.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383099138 28789 80.91.229.3 (30 Oct 2013 02:12:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Oct 2013 02:12:18 +0000 (UTC) Cc: Karl Fogel , 15746@debbugs.gnu.org, Leo Liu To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 03:12:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbLGe-0002K7-Uo for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2013 03:12:21 +0100 Original-Received: from localhost ([::1]:50161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbLGe-0007gZ-2w for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2013 22:12:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbLGU-0007gB-7K for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:12:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbLGM-00034b-UF for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:12:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbLGM-00034W-R2 for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VbLGM-0004jb-G9 for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2013 02:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15746-submit@debbugs.gnu.org id=B15746.138309911818188 (code B ref 15746); Wed, 30 Oct 2013 02:12:02 +0000 Original-Received: (at 15746) by debbugs.gnu.org; 30 Oct 2013 02:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:51785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbLGH-0004jI-U4 for submit@debbugs.gnu.org; Tue, 29 Oct 2013 22:11:58 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:44114) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbLGF-0004j3-4I for 15746@debbugs.gnu.org; Tue, 29 Oct 2013 22:11:55 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsoXfp/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFFsoXfp/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="36645144" Original-Received: from 108-161-119-233.dsl.teksavvy.com (HELO pastel.home) ([108.161.119.233]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Oct 2013 22:11:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4270F608DB; Tue, 29 Oct 2013 22:11:49 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Tue, 29 Oct 2013 13:09:24 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79766 Archived-At: >> I think most users would expect that that *interactively* setting a >> bookmark would confirm when overriding a previous bookmark of the >> same name, instead of just silently overwriting it. > There are plenty of use cases where you want to silently *update* an > existing bookmark, e.g., update its location. How 'bout the following: - change bookmark-set to emit a clear message when it updates an existing message, as well as recording the previous value somewhere. - provide a bookmark-undo command so the user can undo his bookmark-set when he discovers that he has just changed an existing bookmark by mistake. This way, we avoid prompting Drew annoyingly when he knows full well he's updating the bookmark. Leo, would that be sufficient to avoid the regrets, or did you realize too late for a bookmark-undo to be of any use? Stefan