From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: 16804@debbugs.gnu.org
Subject: bug#16804: 24.3.50; [PATCH] fix with-silent-modifications
Date: Wed, 19 Feb 2014 09:28:37 -0500 [thread overview]
Message-ID: <jwvd2ijgour.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <m1a9dniqe2.fsf@gmail.com> (Leo Liu's message of "Wed, 19 Feb 2014 14:10:45 +0800")
>> I vaguely understand what kind of problem you're talking about, but not
>> precisely enough to guess what kinds of fixes might make sense.
> I think the problem is let-binding buffer-file-name and
> buffer-file-truename to nil is a really bad idea. I did a grep on
> buffer-file-name in lisp/ directory and got about 2000 entries. Code at
> distance may run while eval'ing the body of with-silent-modifications
> and affected by the nil value of buffer-file-name etc.
Yes, that's the general understanding I already had, but the particulars
are important as well. Could you give details of the problem you
bump into? Maybe a backtrace showing the sequence of calls that leads
to using buffer-file-name while it's rebound?
Stefan
next prev parent reply other threads:[~2014-02-19 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 0:34 bug#16804: 24.3.50; [PATCH] fix with-silent-modifications Leo Liu
2014-02-19 4:39 ` Stefan Monnier
2014-02-19 6:10 ` Leo Liu
2014-02-19 14:28 ` Stefan Monnier [this message]
2014-02-19 15:35 ` Leo Liu
2014-02-19 18:30 ` Stefan Monnier
2014-02-20 0:33 ` Leo Liu
2014-02-20 4:57 ` Stefan Monnier
2014-02-20 5:57 ` Leo Liu
2014-02-20 14:01 ` Stefan Monnier
2014-02-20 14:38 ` Leo Liu
2014-02-20 17:14 ` Stefan Monnier
2014-02-21 0:29 ` Leo Liu
2016-02-24 3:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd2ijgour.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16804@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.