From: Stefan Monnier <monnier@iro.umontreal.ca>
To: joaotavora@gmail.com (João Távora)
Cc: emacs-devel@gnu.org
Subject: Re: Emacs pretest -- electric-pair-mode change
Date: Thu, 03 Apr 2014 16:54:53 -0400 [thread overview]
Message-ID: <jwvd2gyrvir.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87sipujhq2.fsf@kitaj.lan> ("João Távora"'s message of "Thu, 03 Apr 2014 21:11:49 +0100")
>> Let's say (+ (point) <constant>) falls on the second line of the text
>> below:
>>
>> foo "bar" baz "toto
>> titi
>> tata "tutu" "blabla"
>>
>> should it say "yup, we're within the string 'toto\ntiti\ntata ' or
>> should it say "no, we're not within a string"?
> It will be mistake itself say "everything's fine, proceed with the
> pairing", which is one of the cases where it's wrong, as I had already
> admitted. But when it says "it's wrong,.don't pair" it will be always
> right. And if constant is made big enough the number of mistakes
> decreases (though not by much I admit).
It basically means that we'll always say "don't pair" if (+ (point)
<constant>) is before the last quote in the buffer. If (+ (point)
<constant>) is not near point-max then it'll basically "always" be
before the last quote. So this heuristic reduces to "only try to pair
in the last <constant> chars of the buffer".
>> If we agree that using (point-max) is a bad idea, then the only other
>> option is to try and find some other spot in the buffer (and after
>> point) which is somehow known to be "outside of a string", and in
>> general we don't know how to find such a thing (point-max is the only
>> one we know in general). Hence electric-pair-string-bound-function
>> (or give up on this idea and do something different).
> Hmmm I understand your idea better. Using that with a default
> implementation returning (point-max) might be a good idea, modes that are
> experiencing trouble can then write their complicated versions.
Right.
> I see. I did that syntax-table change thinking *that* would make it
> faster, but it was using `parse-partial-sexp' that did (why?).
Because it avoids syntax-propertize.
> Anyway, I think I could live with those cases of mispairings like
> those here-documents.
Right, but a "mispairing" will throw off all your pairing decisions
before that mispairing. So a mispairing near the end of the file will
throw off your algorithm pretty much all the time, and the user won't
understand it because if/when she decides to go look at the end of the
file, the problem disappears.
I.e. then it *really* becomes unpredictable. And the frequency of
those mispairing depends on the major-mode, since some major modes
depend more on syntax-propertize then others.
Stefan
next prev parent reply other threads:[~2014-04-03 20:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADWZ7fJCws0SO1hEn38CpbRMq+Uw397uCFUnA=YJvOaLVEA8UQ@mail.gmail.com>
2014-03-31 13:27 ` Emacs pretest Stefan Monnier
2014-03-31 13:52 ` Bastien
2014-03-31 14:36 ` Tassilo Horn
2014-03-31 15:55 ` João Távora
2014-03-31 16:34 ` Stefan Monnier
2014-04-02 10:11 ` Emacs pretest -- electric-pair-mode change João Távora
2014-04-02 12:58 ` Stefan Monnier
2014-04-02 17:21 ` João Távora
2014-04-02 22:58 ` Stefan Monnier
2014-04-03 11:06 ` João Távora
2014-04-03 14:22 ` Stefan Monnier
2014-04-03 16:56 ` João Távora
2014-04-03 17:33 ` Stefan Monnier
2014-04-03 20:11 ` João Távora
2014-04-03 20:54 ` Stefan Monnier [this message]
2014-04-04 8:08 ` João Távora
2014-04-04 12:53 ` Stefan Monnier
2014-04-04 23:31 ` João Távora
2014-04-05 15:29 ` Stefan Monnier
2014-04-07 7:43 ` João Távora
2014-04-07 14:04 ` Stefan Monnier
2014-04-04 7:53 ` Eli Zaretskii
2014-04-04 9:49 ` João Távora
2014-04-11 14:42 ` Kevin Rodgers
2014-04-11 15:53 ` Stefan Monnier
2014-04-11 18:23 ` João Távora
2014-04-11 19:58 ` Stefan Monnier
2014-04-12 0:42 ` João Távora
2014-04-11 16:08 ` João Távora
2014-04-03 19:13 ` Eli Zaretskii
2014-04-03 12:15 ` Dmitry Gutov
2014-04-03 13:43 ` João Távora
2014-04-03 15:24 ` Stefan Monnier
2014-04-03 14:24 ` Stefan Monnier
2014-04-01 15:15 ` Emacs pretest Dmitry Antipov
2014-04-01 16:36 ` Dmitry Antipov
2014-04-02 12:37 ` Stefan Monnier
2014-04-01 20:50 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd2gyrvir.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.