From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options. Date: Sun, 14 Dec 2014 09:36:00 -0500 Message-ID: References: <20141214114850.13638.56381@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418567841 15156 80.91.229.3 (14 Dec 2014 14:37:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Dec 2014 14:37:21 +0000 (UTC) Cc: Cameron Desautels To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 14 15:37:14 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0AIL-0006oi-Qs for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 15:37:13 +0100 Original-Received: from localhost ([::1]:36174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0AIK-00028S-Vk for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 09:37:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0AI1-00028M-18 for emacs-devel@gnu.org; Sun, 14 Dec 2014 09:37:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0AHt-0006gy-IY for emacs-devel@gnu.org; Sun, 14 Dec 2014 09:36:52 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0AHt-0006gr-FJ for emacs-devel@gnu.org; Sun, 14 Dec 2014 09:36:45 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEEViMQCzQHCxQYDYh31lkBAQEBBgEBAQEekG8HFoQyBYsBpC6BeII3gWIhgncBAQE X-IPAS-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEEViMQCzQHCxQYDYh31lkBAQEBBgEBAQEekG8HFoQyBYsBpC6BeII3gWIhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="101355506" Original-Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Dec 2014 09:36:30 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3036C175E; Sun, 14 Dec 2014 09:36:00 -0500 (EST) In-Reply-To: (Teodor Zlatanov's message of "Sun, 14 Dec 2014 11:48:51 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180083 Archived-At: Looks good, with the following nitpicks > * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): Add a > mechanism for prompting user about unsaved customizations. These two lines mean "change the custom-prompt-customize-unsaved-options by adding a mechanism for ...", which is not what the patch does. Instead, they should just say * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): New function. Additionally, this text fails to mention custom-unsaved-options or the fact that customize-unsaved has been modified, so I'd write: * lisp/cus-edit.el (custom-unsaved-options): New function, extracted from customize-unsaved. (custom-unsaved): Use it. (custom-prompt-customize-unsaved-options): New function. Feel free to install it, thank you, Stefan