From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: fixing an Elpa package
Date: Sun, 19 Apr 2015 21:52:13 -0400 [thread overview]
Message-ID: <jwvd22zpqyc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wq18hji4.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 19 Apr 2015 11:41:55 +0800")
>>> I guess that makes sense from Git's point of view,
>> If the hashes are the same, then I don't see why it makes sense.
> About 275 commits from the external repo went into Elpa as a single
> squashed commit, ab3b913. The file contents are the same, but I assumed
> Git saw no correspondence between the one squashed and many un-squashed
> commits, and told me I was starting over.
I think the situation is not quite like you say. I tried
git subtree merge --squash -P packages/gnorb gnorb/master
and it did not try to re-add everything. It did try to add too much
("git diff | wc" is a whole 80KB), because in
% git log packages/gnorb/
[...]
commit ce7004456df8d17d1b1bb9b1feab3ddafb1e078a
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Sat Oct 25 08:19:41 2014 -0700
Merging Gnorb commits up to 1.0.1
you somehow managed to "merge" without keeping track of the metadata
("git subtree merge --squash" doesn't keep all commits, but it does
keep the hashes in the commit messages, so "git merge" doesn't
understand what's going on, but "git subtree merge --squash" normally
does, although in the above commit there's no such tracking, so maybe
you didn't use "git subtree merge --squash").
> What's the next step? Commit a removal of the whole subtree, and start
> over?
I installed a dummy commit which merges the tree to which you apparently
sync'd in the above commit, so the above
git subtree merge --squash -P packages/gnorb gnorb/master
now results in much fewer conflicts ("git diff | wc" is a mere 5KB).
So now you just have to use the above command (or another one if you
want to merge another revision than "gnorb/master"), then resolve the
conflicts, then commit and push.
If you need more help, you know where to find me ;-)
> Semi-related question: if a users reports an emacs bug with my package
> in the package header, or it gets tagged later, will an email be
> automatically sent to me as maintainer?
No, we currently don't have such a mechanism in place, sadly.
Stefan
next prev parent reply other threads:[~2015-04-20 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 15:34 fixing an Elpa package Eric Abrahamsen
2015-04-18 17:27 ` Stefan Monnier
2015-04-19 3:41 ` Eric Abrahamsen
2015-04-20 1:52 ` Stefan Monnier [this message]
2015-04-20 5:04 ` Eric Abrahamsen
2015-04-20 12:34 ` Stefan Monnier
2015-04-23 9:20 ` Eric Abrahamsen
2015-04-23 13:19 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd22zpqyc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.