* Re: [Emacs-diffs] master 6a69725: Fix redisplay of frame title when current buffer is killed [not found] ` <E1ZpY1W-0001Rp-5Q@vcs.savannah.gnu.org> @ 2015-10-24 13:46 ` Stefan Monnier 2015-10-24 14:01 ` Eli Zaretskii 0 siblings, 1 reply; 2+ messages in thread From: Stefan Monnier @ 2015-10-24 13:46 UTC (permalink / raw) To: emacs-devel; +Cc: Eli Zaretskii > + /* Killing a buffer might have global effects which require > + redisplaying frames. For example, if the buffer's name appears > + in the frame title. */ > + windows_or_buffers_changed = 11; Hmm... this means that using with-temp-buffer will cause a full redisplay. That's bad. Whats the scenario where this was needed? I mean: if the buffer's name appears in the frame, it's presumably because it's displayed in one of its windows, so place to catch this is when that window's buffer is changed, rather than when a buffer is killed. Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master 6a69725: Fix redisplay of frame title when current buffer is killed 2015-10-24 13:46 ` [Emacs-diffs] master 6a69725: Fix redisplay of frame title when current buffer is killed Stefan Monnier @ 2015-10-24 14:01 ` Eli Zaretskii 0 siblings, 0 replies; 2+ messages in thread From: Eli Zaretskii @ 2015-10-24 14:01 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel > From: Stefan Monnier <monnier@IRO.UMontreal.CA> > Date: Sat, 24 Oct 2015 09:46:07 -0400 > Cc: Eli Zaretskii <eliz@gnu.org> > > > + /* Killing a buffer might have global effects which require > > + redisplaying frames. For example, if the buffer's name appears > > + in the frame title. */ > > + windows_or_buffers_changed = 11; > > Hmm... this means that using with-temp-buffer will cause > a full redisplay. That's bad. Yes, which is why I fixed it differently in bc0b340, which see. > Whats the scenario where this was needed? I mean: if the buffer's name > appears in the frame, it's presumably because it's displayed in one of > its windows, so place to catch this is when that window's buffer is > changed, rather than when a buffer is killed. I thought about that. But changing the name of the frame's selected buffer is just the tip of the iceberg: the frame title accepts all the %-constructs that a mode line accepts, and so should be considered for redisplay whenever we consider mode lines for redisplay. So I eventually set update_mode_lines there, as that is already handled in x_consider_frame_title. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-24 14:01 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20151023084830.5529.17189@vcs.savannah.gnu.org> [not found] ` <E1ZpY1W-0001Rp-5Q@vcs.savannah.gnu.org> 2015-10-24 13:46 ` [Emacs-diffs] master 6a69725: Fix redisplay of frame title when current buffer is killed Stefan Monnier 2015-10-24 14:01 ` Eli Zaretskii
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.