From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Ken Raeburn <raeburn@permabit.com>
Cc: 21688@debbugs.gnu.org
Subject: bug#21688: 25.0.50; abort in regex.c during "align"
Date: Sun, 25 Oct 2015 22:57:54 -0400 [thread overview]
Message-ID: <jwvd1w2uyqw.fsf-monnier+bug#21688@gnu.org> (raw)
In-Reply-To: <6eh9ls35e6.fsf@just-testing.permabit.com> (Ken Raeburn's message of "Thu, 15 Oct 2015 04:25:21 -0400")
> I'm getting an abort in the regex code while doing an align operation on
> some perl code. I've boiled down a test case to reproduce it to this:
[...]
> The abort at 6256 is in the switch statement after the "fail" label.
> Since "pat" is only three bytes into the buffer, the value branched on
> would've been two bytes in, a 1, which is the "succeed" enumerator,
> which isn't expected in that switch statement.
I think the issue is simply that syntax-propertization is now done
on-the-fly during regexp-matching and that this is wrong: the regexp
code is not re-entrant, so if syntax-propertization happens from
regexp-matching and performs regexp-matching itself we're likely to see
weird behaviors.
I think the fix is to make regexp.c use a new
UPDATE_SYNTAX_TABLE_FORWARD_FAST (which doesn't pay attention to
syntax-propertize--done) instead of UPDATE_SYNTAX_TABLE_FORWARD.
Stefan
next prev parent reply other threads:[~2015-10-26 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 8:25 bug#21688: 25.0.50; abort in regex.c during "align" Ken Raeburn
2015-10-26 2:57 ` Stefan Monnier [this message]
2015-11-15 9:34 ` bug#21688: 25.0.50; abort in regex.c during "align",,Previous Next Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvd1w2uyqw.fsf-monnier+bug#21688@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=21688@debbugs.gnu.org \
--cc=raeburn@permabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.