From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face. Date: Tue, 26 Apr 2016 09:51:56 -0400 Message-ID: References: <20160416160638.20718.22687@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461684504 32374 80.91.229.3 (26 Apr 2016 15:28:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 15:28:24 +0000 (UTC) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 17:28:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1av4uG-0002G5-KH for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 17:28:08 +0200 Original-Received: from localhost ([::1]:38426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av4uF-00033l-R7 for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 11:28:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av4u1-00031d-MJ for emacs-devel@gnu.org; Tue, 26 Apr 2016 11:27:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av4tx-0007Od-Kk for emacs-devel@gnu.org; Tue, 26 Apr 2016 11:27:53 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:53382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av4tx-0007OY-GN for emacs-devel@gnu.org; Tue, 26 Apr 2016 11:27:49 -0400 Original-Received: from milanesa.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u3QFRkDO020188; Tue, 26 Apr 2016 11:27:46 -0400 Original-Received: by milanesa.home (Postfix, from userid 20848) id 8B35D6625A; Tue, 26 Apr 2016 09:51:56 -0400 (EDT) In-Reply-To: (Mark Oteiza's message of "Sat, 16 Apr 2016 16:06:38 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5654=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5654> : inlines <4721> : streams <1625660> : uri <2197044> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203340 Archived-At: > Make use of rectangle-preview face. > * lisp/rect.el (rectangle--string-preview): > (rectangle--highlight-for-redisplay): Replace 'region with > 'rectangle-preview (Bug#23248). I think this patch went a bit overboard: `rectangle-preview' supposedly refers to the text-preview in C-x r t, whereas the patch also uses rectangle-preview when you're just selecting a rectangular region. IOW, I think the part of the patch that touched rectangle--string-preview was right, but the part that touched rectangle--highlight-for-redisplay should be reverted. Stefan