From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Mark Oteiza <mvoteiza@udel.edu>
Subject: Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face.
Date: Tue, 26 Apr 2016 09:51:56 -0400 [thread overview]
Message-ID: <jwvd1pclbsj.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1arSk2-0005PF-QA@vcs.savannah.gnu.org> (Mark Oteiza's message of "Sat, 16 Apr 2016 16:06:38 +0000")
> Make use of rectangle-preview face.
> * lisp/rect.el (rectangle--string-preview):
> (rectangle--highlight-for-redisplay): Replace 'region with
> 'rectangle-preview (Bug#23248).
I think this patch went a bit overboard: `rectangle-preview' supposedly
refers to the text-preview in C-x r t, whereas the patch also uses
rectangle-preview when you're just selecting a rectangular region.
IOW, I think the part of the patch that touched
rectangle--string-preview was right, but the part that touched
rectangle--highlight-for-redisplay should be reverted.
Stefan
next parent reply other threads:[~2016-04-26 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160416160638.20718.22687@vcs.savannah.gnu.org>
[not found] ` <E1arSk2-0005PF-QA@vcs.savannah.gnu.org>
2016-04-26 13:51 ` Stefan Monnier [this message]
2016-04-26 15:46 ` [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd1pclbsj.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.