From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23917@debbugs.gnu.org, rpluim@gmail.com, jwiegley@gmail.com,
alex.bennee@linaro.org, nljlistbox2@gmail.com
Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)
Date: Tue, 19 Jul 2016 21:50:07 -0400 [thread overview]
Message-ID: <jwvd1m9dran.fsf-monnier+emacsbugs__7835.23617215014$1468979534$gmane$org@gnu.org> (raw)
In-Reply-To: <834m7l1u8u.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Jul 2016 19:13:21 +0300")
> Do we care that using save-match-data in every call to replace-match
> might mean a performance hit?
I do but:
- to be honest, it's probably lost in the noise.
- if we copy search_regs.start and search_regs.end with something like
alloca+memcpy (instead of calling Fmatch_data), the cost should be even more
lost in the noise. Especially if you consider that the current code
already loops through the match-data to adjust it.
- it's the best fix we've found so far.
> If it will, then this will again punish
> most of the users for the benefit of those few who (1) have
> buffer-modification hooks, and (2) those hooks call save-match-data.
I think the combination of 1 and 2 is actually pretty frequent.
Stefan
PS: I can think of one (theoretical) other/better way to fix this
problem: move the match-data adjustment so it's done within
replace_range before running the after-change-functions. I think
this would be very satisfactory, since it would mean that the Elisp
code would always see the valid match-data (whereas currently the
after-change-functions get passed not-yet-adjusted match-data), so
save-match-data wouldn't mess it up. But I fear this would require
much larger changes (and might involve a heavier performance cost as
well).
next prev parent reply other threads:[~2016-07-20 1:51 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 16:39 org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks Alex Bennée
2016-07-15 17:39 ` Eli Zaretskii
2016-07-15 19:12 ` Alex Bennée
2016-07-15 19:37 ` Noam Postavsky
2016-07-15 21:56 ` Alex Bennée
2016-07-16 16:01 ` Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) N. Jackson
2016-07-16 16:11 ` Eli Zaretskii
2016-07-16 17:09 ` John Wiegley
2016-07-17 17:28 ` Alex Bennée
2016-07-17 17:41 ` Eli Zaretskii
2016-07-18 12:24 ` bug#23917: " Robert Pluim
2016-07-18 12:24 ` Robert Pluim
2016-07-18 18:09 ` Eli Zaretskii
2016-07-18 19:04 ` John Wiegley
2016-07-18 19:04 ` John Wiegley
2016-07-18 19:10 ` Eli Zaretskii
2016-07-18 19:10 ` Eli Zaretskii
2016-07-19 0:58 ` Stefan Monnier
2016-07-19 0:58 ` Stefan Monnier
2016-07-19 2:40 ` Eli Zaretskii
2016-07-19 4:48 ` Stefan Monnier
2016-07-19 4:48 ` Stefan Monnier
2016-07-19 15:35 ` Eli Zaretskii
2016-07-19 16:03 ` Stefan Monnier
2016-07-19 16:03 ` Stefan Monnier
2016-07-19 16:13 ` Eli Zaretskii
2016-07-19 17:05 ` bug#23917: [O] " Alex Bennée
2016-07-19 17:20 ` bug#23917: " Eli Zaretskii
2016-07-19 17:20 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 17:45 ` Alex Bennée
2016-07-19 18:07 ` Sebastian Wiesner
2016-07-19 18:07 ` bug#23917: " Sebastian Wiesner
2016-07-19 18:44 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 18:44 ` bug#23917: " Eli Zaretskii
2016-07-20 9:48 ` bug#23917: " Alex Bennée
2016-07-20 9:48 ` bug#23917: [O] " Alex Bennée
2016-07-20 14:59 ` bug#23917: " Eli Zaretskii
2016-07-20 14:59 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 17:45 ` Alex Bennée
2016-07-19 17:05 ` Alex Bennée
2016-07-20 1:50 ` Stefan Monnier
2016-07-20 14:55 ` Eli Zaretskii
2016-07-20 18:19 ` Stefan Monnier
2016-07-20 18:55 ` Eli Zaretskii
2016-07-20 18:55 ` Eli Zaretskii
2016-07-20 20:54 ` Stefan Monnier
2016-07-21 0:56 ` npostavs
2016-07-21 0:56 ` npostavs
2016-07-21 1:47 ` Stefan Monnier
2016-07-21 1:47 ` Stefan Monnier
2016-07-21 2:34 ` Noam Postavsky
2016-07-21 3:06 ` Stefan Monnier
2016-07-21 3:06 ` Stefan Monnier
2016-07-21 2:34 ` Noam Postavsky
2016-07-21 2:43 ` Eli Zaretskii
2016-07-21 3:00 ` npostavs
2016-07-21 3:00 ` npostavs
2016-07-21 14:26 ` Eli Zaretskii
2016-07-21 14:26 ` Eli Zaretskii
2016-07-22 1:08 ` npostavs
2016-07-22 1:08 ` npostavs
2016-07-22 6:43 ` Eli Zaretskii
2016-07-22 14:01 ` Robert Pluim
2016-07-22 14:01 ` Robert Pluim
2016-07-22 19:30 ` Nicolas Petton
2016-07-22 19:30 ` Nicolas Petton
2016-07-23 4:19 ` npostavs
2016-07-23 4:19 ` npostavs
2016-07-22 6:43 ` Eli Zaretskii
2016-07-23 0:42 ` bug#23917: Re: bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-23 0:42 ` N. Jackson
2016-07-23 7:38 ` Eli Zaretskii
2016-07-23 7:38 ` Eli Zaretskii
2016-07-21 2:43 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) Eli Zaretskii
2016-07-21 7:59 ` bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-21 8:19 ` Robert Pluim
2016-07-21 8:19 ` Robert Pluim
2016-07-08 12:42 ` Robert Pluim
2016-07-08 14:02 ` Eli Zaretskii
2016-07-08 15:40 ` Robert Pluim
2016-07-08 17:03 ` Eli Zaretskii
2016-07-08 17:03 ` Eli Zaretskii
2016-07-15 19:46 ` Eli Zaretskii
2016-07-15 19:46 ` Eli Zaretskii
2016-07-21 14:24 ` N. Jackson
2016-07-21 14:24 ` N. Jackson
2016-07-21 7:59 ` N. Jackson
2016-07-20 20:54 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) Stefan Monnier
2016-07-20 18:19 ` Stefan Monnier
2016-07-20 14:55 ` Eli Zaretskii
2016-07-20 1:50 ` Stefan Monnier [this message]
2016-07-19 16:13 ` Eli Zaretskii
2016-07-19 23:18 ` npostavs
2016-07-19 23:18 ` npostavs
2016-07-19 15:35 ` Eli Zaretskii
2016-07-19 2:40 ` Eli Zaretskii
2016-07-19 15:36 ` Eli Zaretskii
2016-07-19 15:36 ` Eli Zaretskii
2016-07-21 7:52 ` bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-21 7:52 ` N. Jackson
2016-07-21 8:08 ` Robert Pluim
2016-07-21 13:19 ` N. Jackson
2016-07-21 13:19 ` N. Jackson
2016-07-21 8:08 ` Robert Pluim
2016-07-18 18:09 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) Eli Zaretskii
2016-07-18 14:50 ` Kaushal Modi
2016-07-18 14:50 ` Kaushal Modi
[not found] ` <9613abde4dbd48fdb2b5e780101a13a0@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2016-07-18 16:59 ` Eric S Fraga
2016-07-18 16:59 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvd1m9dran.fsf-monnier+emacsbugs__7835.23617215014$1468979534$gmane$org@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=23917@debbugs.gnu.org \
--cc=alex.bennee@linaro.org \
--cc=eliz@gnu.org \
--cc=jwiegley@gmail.com \
--cc=nljlistbox2@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.