From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#24548: 25.2.50; Long GC delays with many non-detached markers (PATCH) Date: Fri, 23 Mar 2018 09:55:15 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521813289 1345 195.159.176.226 (23 Mar 2018 13:54:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2018 13:54:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24548@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 23 14:54:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezN9Z-0000FN-3J for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 14:54:45 +0100 Original-Received: from localhost ([::1]:38193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNBc-0003Ho-7s for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 09:56:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNAr-0002t0-Vt for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 09:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNAo-0006pu-7y for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 09:56:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezNAo-0006pk-3v for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 09:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezNAn-0004cw-N5 for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 09:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2018 13:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24548-submit@debbugs.gnu.org id=B24548.152181331917669 (code B ref 24548); Fri, 23 Mar 2018 13:56:01 +0000 Original-Received: (at 24548) by debbugs.gnu.org; 23 Mar 2018 13:55:19 +0000 Original-Received: from localhost ([127.0.0.1]:49689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNA6-0004ao-Tz for submit@debbugs.gnu.org; Fri, 23 Mar 2018 09:55:19 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNA4-0004WZ-G8 for 24548@debbugs.gnu.org; Fri, 23 Mar 2018 09:55:17 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2NDtFtv032439; Fri, 23 Mar 2018 09:55:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 320F560223; Fri, 23 Mar 2018 09:55:15 -0400 (EDT) In-Reply-To: (Pip Cet's message of "Mon, 26 Sep 2016 15:12:10 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6249=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6249> : inlines <6514> : streams <1782034> : uri <2613418> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144557 Archived-At: > I thought it would be very easy to modify the code to avoid the problem; > it was a bit harder than I thought, because the GC mark bit is not > equivalent to "this object survives the current GC cycle". Could you give a bit more details about what you mean by that? During the mark phase, indeed the markbit only says "if true then this object won't be GC'd but if false than maybe it's only because we haven't finished marking". Is that what you're referring to? But if we call unchain_collected_markers from within the sweep phase (e.g. on every buffer we find), `gcmarkbit` should be sufficient/reliable. Or am I missing something? Stefan