From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Performance issue w/ `cl-loop`s `collect...into`
Date: Sun, 08 Apr 2018 21:59:25 -0400 [thread overview]
Message-ID: <jwvd0z987m3.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: CACMkxizQ=MJMrfRrmUFBp-1Lu+RC8FvUpQLhgnk-7eEUTX809A@mail.gmail.com
> Here's a second, cleaner attempt that separates the `cl--loop-handle-accum`
> function into two functions, one to deal with lists and one to deal w/
> non-lists.
> The tail-tracking optimizing is also applied to `append(ing)` and
> `nconc(ing)`.
Thanks. Looks good.
I see you've dropped the (eq var cl--loop-accum-var) optimization.
Have you tried to measure the effect?
Stefan
> +(defun cl--loop-handle-accum (def)
[...]
> + (cond
[...]
> + (cl--loop-accum-var cl--loop-accum-var)
You can write this line as just
(cl--loop-accum-var)
-- Stefan
next prev parent reply other threads:[~2018-04-09 1:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 0:51 Performance issue w/ `cl-loop`s `collect...into` Tianxiang Xiong
2018-04-08 3:26 ` Clément Pit-Claudel
2018-04-08 5:56 ` Tianxiang Xiong
2018-04-08 6:12 ` Clément Pit-Claudel
2018-04-08 8:50 ` Tianxiang Xiong
2018-04-08 13:19 ` Clément Pit-Claudel
2018-04-08 16:07 ` Stefan Monnier
2018-04-08 19:58 ` Tianxiang Xiong
2018-04-08 21:13 ` Stefan Monnier
2018-04-08 23:29 ` Tianxiang Xiong
2018-04-09 1:10 ` Tianxiang Xiong
2018-04-09 1:59 ` Stefan Monnier [this message]
2018-04-09 2:16 ` Tianxiang Xiong
2018-04-09 2:20 ` Stefan Monnier
2018-04-09 3:34 ` Tianxiang Xiong
2018-04-09 3:38 ` Tianxiang Xiong
2018-04-09 12:07 ` Stefan Monnier
2018-04-09 12:22 ` Basil L. Contovounesios
2018-04-09 15:28 ` Tianxiang Xiong
2018-04-09 15:33 ` Tianxiang Xiong
2018-04-14 7:01 ` Tianxiang Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd0z987m3.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.