all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tadeus Prastowo <tadeus.prastowo@unitn.it>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [pcomplete.el (pcomplete-completions-at-point)] Why max?
Date: Wed, 20 Mar 2019 10:00:55 -0400	[thread overview]
Message-ID: <jwvd0mlprz2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAN-HRFbdOBc_6_7nSFOXZ2DLAYXX6pGK4Mi-HKKsESzx03C0Dg@mail.gmail.com> (Tadeus Prastowo's message of "Wed, 20 Mar 2019 12:00:13 +0100")

> $ emacs -Q
> M-x shell
> cd /tmp
> mkdir ABCD\ EF\ GHIJKL
> cd ABCD\ EF<tab>
>
> The echo area shows "No match".

I see it now!
I just pushed the fix below which seems to do the trick!


        Stefan


 * lisp/minibuffer.el (completion-table-subvert): Fix typo from rev 5697ca55cb

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index df0acbb343..dbd24dfa0a 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -269,7 +269,7 @@ completion-table-subvert
                     (+ beg (- (length s1) (length s2))))
               . ,(and (eq (car-safe res) 'boundaries) (cddr res)))))
          ((stringp res)
-          (if (string-prefix-p s2 string completion-ignore-case)
+          (if (string-prefix-p s2 res completion-ignore-case)
               (concat s1 (substring res (length s2)))))
          ((eq action t)



  reply	other threads:[~2019-03-20 14:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 22:29 [pcomplete.el (pcomplete-completions-at-point)] Why max? Tadeus Prastowo
2019-03-19  9:55 ` Tadeus Prastowo
2019-03-19 16:37   ` Stefan Monnier
2019-03-19 16:40     ` Tadeus Prastowo
2019-03-20  2:09 ` Stefan Monnier
2019-03-20 11:00   ` Tadeus Prastowo
2019-03-20 14:00     ` Stefan Monnier [this message]
2019-03-20 16:14       ` Tadeus Prastowo
2019-03-20 17:11         ` Stefan Monnier
2019-03-20 17:17           ` Tadeus Prastowo
2019-03-20 23:38           ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd0mlprz2.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=tadeus.prastowo@unitn.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.