From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Line height issues with display-line-number-mode Date: Wed, 08 May 2019 10:17:38 -0400 Message-ID: References: <6fd496f0-7dd5-6c0e-5121-b618e7dca831@gmail.com> <83sgtqi02k.fsf@gnu.org> <83r29ahyz2.fsf@gnu.org> <83pnouhwxs.fsf@gnu.org> <83ef59igzc.fsf@gnu.org> <83tve5ghyd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="264137"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 16:19:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hONPQ-0016W1-WB for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 16:19:01 +0200 Original-Received: from localhost ([127.0.0.1]:38008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONPP-0007uw-Tn for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 10:18:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONOF-0007tB-8W for emacs-devel@gnu.org; Wed, 08 May 2019 10:17:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hONOE-0003vV-8d for emacs-devel@gnu.org; Wed, 08 May 2019 10:17:47 -0400 Original-Received: from [195.159.176.226] (port=38646 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hONOE-0003ui-16 for emacs-devel@gnu.org; Wed, 08 May 2019 10:17:46 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hONOC-0015EU-65 for emacs-devel@gnu.org; Wed, 08 May 2019 16:17:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:02MVAN15eVaJxL/52Nev/LPvUP4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236293 Archived-At: >> > Btw, any reasons (other than "because we can") why we use these >> > tricks, instead of actually producing an underline? >> Not sure what "producing an underline" means concretely. > Using the 'underline' face, obviously. I did guess this part ;-) But what text would you apply it to? >> > when we produce line numbers, so that we start the layout of the rest >> > of the line with the height of, say, 1 pixel, and let the rest of the >> > line's text enlarge that as needed. But doing this naïvely would >> > backfire with various special cases, like empty lines, lines with >> > characters whose font-provided height is small, etc.: those lines will >> > appear smaller in height, >> Smaller than what? > Smaller than other lines. That wouldn't be a problem but a feature: those lines are smaller than other lines when line-numbers are not displayed, so it's not a problem if they're also smaller when line-numbers are displayed. >> AFAICT they wouldn't appear any smaller than when line-numbers are >> turned off, or would they? > They might, I'm not sure. If it makes them smaller than without line-numbers, then it's indeed a problem, but I wonder why/when that would happen. Stefan