From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer
Date: Tue, 28 May 2019 13:25:17 -0400 [thread overview]
Message-ID: <jwvd0k2v6iv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83y32qzk9b.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 May 2019 18:11:44 +0300")
> OK, but how does this affect the issue at hand? We want to replace
> string-as-unibyte, or remove it, and the obsolescence message says to
> replace it with encode-coding-string.
But this obsolescence message assumes that the call to string-as-unibyte
was used because of a need to encode the strings using Emacs's internal
coding-system. In this case, the string is already encoded (as stated
by the function's name, the docstring, ...), so using
encode-coding-string is rather odd.
Also using string-to-unibyte will correctly signal an error if the
caller forgot to send an *encoded* string.
> Either way, using string-to-unibyte instead sounds less desirable
> to me.
I agree that removing the call altogether is the better option.
Stefan
next prev parent reply other threads:[~2019-05-28 17:25 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190525191039.14136.23307@vcs0.savannah.gnu.org>
[not found] ` <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org>
2019-05-25 19:41 ` [Emacs-diffs] emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Stefan Monnier
2019-05-25 19:59 ` Eli Zaretskii
2019-05-25 20:15 ` Eli Zaretskii
2019-05-25 21:11 ` Stefan Monnier
2019-05-25 21:27 ` Stefan Monnier
2019-05-26 2:37 ` Eli Zaretskii
2019-05-27 9:47 ` Robert Pluim
2019-05-27 12:24 ` Stefan Monnier
2019-05-27 13:02 ` Robert Pluim
2019-05-27 13:32 ` Stefan Monnier
2019-05-27 13:49 ` Robert Pluim
2019-05-27 16:53 ` Eli Zaretskii
2019-05-28 6:23 ` Robert Pluim
2019-05-28 14:57 ` Eli Zaretskii
2019-05-28 3:08 ` Stefan Monnier
2019-05-28 4:40 ` Eli Zaretskii
2019-05-28 11:55 ` Stefan Monnier
2019-05-28 15:18 ` Eli Zaretskii
2019-05-28 17:43 ` Stefan Monnier
2019-05-28 18:58 ` Eli Zaretskii
2019-05-28 19:35 ` Eli Zaretskii
2019-05-28 23:44 ` Stefan Monnier
2019-05-29 14:33 ` Eli Zaretskii
2019-05-27 16:51 ` Eli Zaretskii
2019-05-27 19:17 ` Stefan Monnier
2019-05-28 2:30 ` Eli Zaretskii
2019-05-28 2:56 ` Stefan Monnier
2019-05-28 4:17 ` Eli Zaretskii
2019-05-28 6:21 ` Robert Pluim
2019-05-28 11:53 ` Stefan Monnier
2019-05-28 11:54 ` Stefan Monnier
2019-05-28 15:11 ` Eli Zaretskii
2019-05-28 17:25 ` Stefan Monnier [this message]
2019-05-28 18:51 ` Eli Zaretskii
2019-05-28 23:39 ` Stefan Monnier
2019-05-29 2:45 ` Eli Zaretskii
2019-05-29 16:28 ` Stefan Monnier
2019-05-29 18:19 ` Eli Zaretskii
2019-05-29 18:58 ` Stefan Monnier
2019-05-29 19:09 ` Eli Zaretskii
2019-05-29 19:50 ` Stefan Monnier
2019-05-27 16:43 ` Eli Zaretskii
2019-05-27 16:42 ` Eli Zaretskii
2019-05-27 19:13 ` Stefan Monnier
2019-05-27 16:40 ` Eli Zaretskii
2019-05-27 20:17 ` Richard Stallman
2019-05-28 2:36 ` Eli Zaretskii
2019-05-28 7:06 ` Robert Pluim
2019-05-28 14:59 ` Eli Zaretskii
2019-05-28 15:11 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd0k2v6iv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.