Desired behavior on splitting screens in xwidget Webkit Browser

Desired behavior on splitting screens in xwidget Webkit Browser

[조성빈]

I’m currently writing a patch to add the xwidget Webkit Browser in macOS Cocoa.

Currently, displaying one xwidgets in two different buffers is not supported.
In my current patch, I remap C-x 3 and C-x 4 to functions that create another xwidget browser with the same URL, but it feels slow when using and I found it tedious as I usually split my screen in half and switch to another buffer.

What should be the desired behavior when splitting buffers in the xwidget Webkit Browser?

Re: Desired behavior on splitting screens in xwidget Webkit Browser

[Stefan Monnier]

> Currently, displaying one xwidgets in two different buffers is not supported.

But the user can still cause it to happen.  What happens in this case?

> What should be the desired behavior when splitting buffers in the
> xwidget Webkit Browser?

Maybe it should just do the split "normally" with one of the two windows
displaying the xwidget and the other displaying some kind of "error
information".

You'll probably want to keep the kind of "clone" commands you currently
have under C-x 2 and C-x 3, but let the user request them explicitly
(e.g. under a different key-binding).


        Stefan

Re: Desired behavior on splitting screens in xwidget Webkit Browser

[조성빈]

> 2019. 7. 20. 오전 1:09, Stefan Monnier <monnier@iro.umontreal.ca> 작성:
> 
>> Currently, displaying one xwidgets in two different buffers is not supported.
> 
> But the user can still cause it to happen.  What happens in this case?

The xwidget buffer shows nothing, with an error message ‘Viewing two xwidget buffers simultaneously is not supported.'

>> What should be the desired behavior when splitting buffers in the
>> xwidget Webkit Browser?
> 
> Maybe it should just do the split "normally" with one of the two windows
> displaying the xwidget and the other displaying some kind of "error
> information”.

Yeah, I think that’s probably right :-)

> You'll probably want to keep the kind of "clone" commands you currently
> have under C-x 2 and C-x 3, but let the user request them explicitly
> (e.g. under a different key-binding).

OK.

> 
>        Stefan
> 

Re: Desired behavior on splitting screens in xwidget Webkit Browser

[Stefan Monnier]

>>> Currently, displaying one xwidgets in two different buffers is
>>> not supported.
>> But the user can still cause it to happen.  What happens in this case?
> The xwidget buffer shows nothing, with an error message ‘Viewing two xwidget
> buffers simultaneously is not supported.'

Does it show this error message on both (i.e. all) windows where the
buffer is displayed?  If so, then I think it would be worthwhile to try
and improve the code so one of the windows gets to be functional (while
the others display the error message).


        Stefan

Re: Desired behavior on splitting screens in xwidget Webkit Browser

[조성빈]

> 2019. 7. 20. 오전 1:16, Stefan Monnier <monnier@iro.umontreal.ca> 작성:
> 
>>>> Currently, displaying one xwidgets in two different buffers is
>>>> not supported.
>>> But the user can still cause it to happen.  What happens in this case?
>> The xwidget buffer shows nothing, with an error message ‘Viewing two xwidget
>> buffers simultaneously is not supported.'
> 
> Does it show this error message on both (i.e. all) windows where the
> buffer is displayed?  If so, then I think it would be worthwhile to try
> and improve the code so one of the windows gets to be functional (while
> the others display the error message).

No, the original one keeps functional. (The others display the error message as you said.)

>        Stefan
> 
> 

Re: Desired behavior on splitting screens in xwidget Webkit Browser

[Stefan Monnier]

> No, the original one keeps functional. (The others display the error
> message as you said.)

Then I think it's "good enough".


        Stefan