From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: 7 logical-xor implementations in source tree Date: Wed, 24 Jul 2019 19:15:27 -0400 Message-ID: References: <87tvbd9a8p.fsf@oremacs.com> <87pnm14u95.fsf@tcd.ie> <87sgqvoz5c.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31428"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Oleh Krehel To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 25 01:15:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqQU0-00081m-PL for ged-emacs-devel@m.gmane.org; Thu, 25 Jul 2019 01:15:41 +0200 Original-Received: from localhost ([::1]:54942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqQTz-0005sl-7C for ged-emacs-devel@m.gmane.org; Wed, 24 Jul 2019 19:15:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59516) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqQTv-0005sG-LU for emacs-devel@gnu.org; Wed, 24 Jul 2019 19:15:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqQTu-00034e-Ps for emacs-devel@gnu.org; Wed, 24 Jul 2019 19:15:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24615) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqQTu-00034C-IQ for emacs-devel@gnu.org; Wed, 24 Jul 2019 19:15:34 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9520481A2C; Wed, 24 Jul 2019 19:15:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 179518007A; Wed, 24 Jul 2019 19:15:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564010129; bh=zt0Ifu4Hypg2ID09a7sgMpZ5frN3mKyo8LIV4qbUg8M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=f3JidN4D6rpq37RW5xAwtClj+ayEHamH+JA5ZEgK8bDsIH5CUrhqz93VBNe5LfLr6 rDcUhUgaG6b9lfqz3T25p5YlegqUc5pz0BMjVENu8e0S6ZK3lwvg2c7gTGU3NvgpL9 IMLBhyLb07x7Yi9qMPHlDbJz6pbQpARLru9zPW3nPA6cXaG7mfm9a/RFX/IQNl3zVL MH7HKckCSpioK7PMBPrbI0KZfChjV3t1sZmwj6IegvxhJ34v8G/hSLitdGWFq1RrNg KzeI3FubVKs7BXGITlx0m6iKPq1qwrk5cDN4VVTbo3ADJJGTDQaRsYihwnY1WuARBf gyZqvaTc8bU5w== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 93752120436; Wed, 24 Jul 2019 19:15:28 -0400 (EDT) In-Reply-To: <87sgqvoz5c.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 24 Jul 2019 23:17:51 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238875 Archived-At: > It defines xor using defsubst instead of define-inline, so that it can > be included in subr.el. Great, thanks. > Would defun be preferred instead? No proeference here. > It also includes Mattias' equiv suggestion. Not convinced about this one: - The name is too much like "equal/eq/eql": we need something much more explicit to avoid adding to the already existing confusion. I'd go with something like `bool-equal`. - The fact that it's not a function is a definite downside. - There's no use for it, currently. If we can't find any use for it, I'm not sure it deserves to be in subr.el. Actual/potential uses of it might also help figure out if having it as a function would be beneficial/useful and whether the detail about which non-nil value is returned is important and whether supporting more than 2 args is important. Stefan