From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org, Oleh Krehel <oleh@oremacs.com>
Subject: Re: 7 logical-xor implementations in source tree
Date: Wed, 24 Jul 2019 19:15:27 -0400 [thread overview]
Message-ID: <jwvd0hzqbb6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87sgqvoz5c.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 24 Jul 2019 23:17:51 +0100")
> It defines xor using defsubst instead of define-inline, so that it can
> be included in subr.el.
Great, thanks.
> Would defun be preferred instead?
No proeference here.
> It also includes Mattias' equiv suggestion.
Not convinced about this one:
- The name is too much like "equal/eq/eql": we need something much
more explicit to avoid adding to the already existing confusion.
I'd go with something like `bool-equal`.
- The fact that it's not a function is a definite downside.
- There's no use for it, currently. If we can't find any use for it,
I'm not sure it deserves to be in subr.el.
Actual/potential uses of it might also help figure out if having it as
a function would be beneficial/useful and whether the detail about
which non-nil value is returned is important and whether supporting
more than 2 args is important.
Stefan
next prev parent reply other threads:[~2019-07-24 23:15 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:48 7 logical-xor implementations in source tree Oleh Krehel
2019-07-22 21:47 ` Basil L. Contovounesios
2019-07-24 22:17 ` Basil L. Contovounesios
2019-07-24 23:15 ` Stefan Monnier [this message]
2019-07-24 23:44 ` Basil L. Contovounesios
2019-07-25 12:07 ` Mattias Engdegård
2019-07-25 17:28 ` Paul Eggert
2019-07-25 17:46 ` Mattias Engdegård
2019-07-28 7:09 ` Philippe Schnoebelen
2019-07-28 8:04 ` Alan Mackenzie
2019-07-28 19:43 ` Marcin Borkowski
2019-07-30 9:36 ` Alan Mackenzie
2019-07-30 10:57 ` Philippe Schnoebelen
2019-07-30 11:28 ` Andy Moreton
2019-07-30 12:34 ` Stefan Monnier
2019-07-30 14:25 ` Barry Fishman
2019-07-31 3:16 ` Richard Stallman
2019-07-31 15:20 ` Barry Fishman
2019-07-31 15:42 ` Stefan Monnier
2019-07-31 20:22 ` Basil L. Contovounesios
2019-07-31 21:15 ` Michael Heerdegen
2019-07-31 22:28 ` Mattias Engdegård
2019-07-31 23:39 ` Basil L. Contovounesios
2019-08-02 10:29 ` Mattias Engdegård
2019-08-02 10:59 ` Basil L. Contovounesios
2019-08-06 11:58 ` Mattias Engdegård
2019-07-31 20:31 ` Michael Heerdegen
2019-07-31 21:38 ` Drew Adams
2019-07-31 22:03 ` Drew Adams
2019-07-31 22:05 ` Basil L. Contovounesios
2019-07-31 23:20 ` Drew Adams
2019-08-01 0:09 ` Basil L. Contovounesios
2019-07-31 17:12 ` Marcin Borkowski
2019-07-23 8:39 ` Andy Moreton
2019-07-23 9:08 ` Basil L. Contovounesios
2019-07-23 9:14 ` Mattias Engdegård
2019-07-23 10:26 ` Andy Moreton
2019-07-23 10:40 ` Andreas Schwab
2019-07-23 12:11 ` Andy Moreton
2019-07-23 13:20 ` Basil L. Contovounesios
2019-07-23 13:54 ` Andy Moreton
2019-07-24 22:21 ` Basil L. Contovounesios
2019-07-23 10:44 ` Basil L. Contovounesios
2019-07-23 11:01 ` Yuri Khan
2019-07-25 21:46 ` Juri Linkov
2019-07-23 11:24 ` Noam Postavsky
2019-07-23 12:38 ` Stefan Monnier
2019-07-23 16:41 ` Mattias Engdegård
2019-07-23 17:12 ` Eli Zaretskii
2019-07-23 17:48 ` Paul Eggert
2019-07-23 19:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd0hzqbb6.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=oleh@oremacs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.