From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eric Ludlam <eric@siege-engine.com>
Cc: Emacs Development <emacs-devel@gnu.org>
Subject: Re: eieio-base patch to support EDE project loading
Date: Sun, 06 Oct 2019 16:02:15 -0400 [thread overview]
Message-ID: <jwvd0f91w69.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <13d0ce18-013c-94b7-ea2e-bef5a6687bb4@siege-engine.com> (Eric Ludlam's message of "Sun, 6 Oct 2019 08:18:08 -0400")
> Patch looks like a good idea to me. I was worried about overhead of always
> checking and un-autoloading, but this patch seems to deal with that nicely.
Right, I think it's only used in places which should hopefully not be
performance-sensitive.
> The original problem arose when trying to identify the class
> parents. Perhaps using eieio--full-class-object in eieio-class-parents would
> cast a slightly wider net?
eieio-class-parents is not used internally, so it's not sufficient, but
it's indeed a good idea to make it load the class if needed, so I made
that change as well.
>> Can you test the patch below before I push it?
> It works great. Thanks for looking into it!
Great, pushed to `master`, thanks,
Stefan
prev parent reply other threads:[~2019-10-06 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 2:18 eieio-base patch to support EDE project loading Eric Ludlam
2019-10-01 12:14 ` Stefan Monnier
2019-10-04 20:45 ` Stefan Monnier
2019-10-06 12:18 ` Eric Ludlam
2019-10-06 20:02 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd0f91w69.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=eric@siege-engine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.