From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Dedicated window for *log-edit-files* Date: Fri, 25 Oct 2019 08:48:27 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165448"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 25 14:49:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNz2N-000gtK-H3 for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 14:49:51 +0200 Original-Received: from localhost ([::1]:59508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNz2M-0007RN-6O for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 08:49:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54851) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNz1G-0007NA-9i for emacs-devel@gnu.org; Fri, 25 Oct 2019 08:48:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNz1E-0001NO-LZ for emacs-devel@gnu.org; Fri, 25 Oct 2019 08:48:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56039) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNz1E-0001Mv-FE for emacs-devel@gnu.org; Fri, 25 Oct 2019 08:48:40 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A2F371004C7; Fri, 25 Oct 2019 08:48:38 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2DDA11002CF; Fri, 25 Oct 2019 08:48:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572007717; bh=5eUz4GrWwolbRT4uAkEMW42h3jS+/IXZDyZO26OGysM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GZrF9EQMCIu0CSnIJieuKJo6JcYjB0Nsp7w55elJzhNqg2NmVEhTf4NqpiDoTly97 ed28BJ0hyIjZkcEP4TCtwoHLUBCf5KyU24aRxmrsKMp7rIobXKuR4+SMlbNYSvZGCH UEkJBzcmAR76+0I52c5l6ZOZzNVae9sW8DRuK0EfBM0QhbJEQmXysasoBuKVO9r5St dLJ1cY03x3XsMcSrQLVk2KzA0xbvYSELEq5NBbGk5OrjaSkNrla4FqzCsdEnS6xB6j MebqjA2acWJIqwvVvgWLh+TqYtX6i20qAIFzSjw0SCDbebkwQ21LH6Cs3WcvgKBcy9 6lqSkfzVkzVYg== Original-Received: from pastel (unknown [216.154.30.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E8BF9120403; Fri, 25 Oct 2019 08:48:36 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Fri, 25 Oct 2019 12:48:19 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241409 Archived-At: Jo=E3o T=E1vora [2019-10-25 12:48:19] wrote: > When finalizing a commit with VC, (I usually do it from vc-next-action > but maybe there are other ways), a buffer and a window popup for > *log-edit-files*, showing the files touched by the "commit" (here > I'm using "commit" to designate the corresponding VC action > across VCSystems). > > For me personally, the window is quite annoying because it's > in the path of my "C-x o" workflow: very frequently I want to jump > back to the source buffer to do some last minute adjustment. > > My questions are: > > 1. can I get rid of the `*log-edit-files*` window & buffer? > 1.2. what about just the window? Remove `log-edit-show-files` from `log-edit-hook`. [ Yes, non-nil default values for non-preloaded hooks are evil. I confess to doing it, but I plead insanity. ] > 2. does the buffer serve any other purpose besides > informing me? No. > 3. supposing the answer to 2 is "No" would some overlay text in the > *vc-log* buffer, much like the overlay trickery that is already done > there, server the same purpose? That could work, but I think a separate buffer&window is just as well (makes it easier to copy&paste, hide, etc...). Maybe we should arrange for `C-x o` not to switch to it (on GUI frames you could still point&click to select it in those rare cases that you want to, not sure what UI to use for the tty case: maybe just force the user to C-x b to the *log-edit-files* buffer in another window). Stefan